-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransformerEngine doesn't work with uv #1323
Comments
I think that setup.py's mechanism of deciding which frameworks to build based on presence in the current python environment is incompatible with how uv works, i.e., packages are built in a clean python environment. |
TE has these hard-coded Pip calls to work around two problems:
The "right" solution to 1 is adding a Fixing 2 is trickier and would require a revamp of our build infrastructure. It seems to me that the right approach is to install separate framework packages when building from source, so that the structure matches the PyPI case. Pinging @ksivaman. If you can't rely on automatically detecting which DL frameworks are installed, then the best approach is to set |
setup.py
calls uninstall_te_wheel_packages which fails becausepip
is not a module. This is expected because I use uv instead of pip. I think TransformerEngine should not assume pip.Full error:
The text was updated successfully, but these errors were encountered: