Disable validation/test stages in ESM-2 and Geneformer #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichu2023
requested review from
jstjohn,
malcolmgreaves,
skothenhill-nv,
farhadrgh,
dorotat-nv and
pstjohn
as code owners
sichu2023
changed the title
|
/build-ci |
jstjohn
approved these changes
Dec 3, 2024
Will do. Just disabled auto-merge. |
sichu2023
force-pushed
the
sichu/limit-val-batches=0p0
branch
from
b4a7b5f to
a61d0b5
Compare
|
/build-ci |
Done! |
farhadrgh
approved these changes
Dec 4, 2024
pstjohn
approved these changes
Dec 4, 2024
sub-packages/bionemo-geneformer/tests/bionemo/geneformer/scripts/test_train_geneformer.py
Show resolved
Hide resolved
sichu2023
force-pushed
the
sichu/limit-val-batches=0p0
branch
2 times, most recently
from
0eeb34b to
2f89e94
Compare
|
/build-ci |
sichu2023
force-pushed
the
sichu/limit-val-batches=0p0
branch
from
ddc9672 to
8b50d57
Compare
|
/build-ci |
sichu2023
force-pushed
the
sichu/limit-val-batches=0p0
branch
from
8b50d57 to
386ad33
Compare
|
/build-ci |
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
--limit-val-batches=0.to disable validation. Same applies for testing in geneformer.Details
Previously validation dataset cannot be created when
limit_val_batches = 0.. Now this is caught and the validation dataset is set toNone. Same applies to test dataset.Tests
Implemented in
sub-packages/bionemo-geneformer/tests/bionemo/esm2/scripts/test_train_esm2.py::test_val_dataloader_in_main_runs_with_limit_val_batchesand that in geneformer.Out of scope