-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA][webdatamodule]: support webdataset invocable #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/build-ci |
DejunL
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves and
pstjohn
as code owners
December 5, 2024 00:57
/build-ci |
jstjohn
approved these changes
Dec 6, 2024
pstjohn
approved these changes
Dec 6, 2024
DejunL
force-pushed
the
dejunl/wdm-invoke
branch
from
December 6, 2024 17:41
1699592
to
45c8088
Compare
/build-ci |
/build-ci |
keep getting CI failure in docker image building:
which seems to result from:
|
/build-ci |
2 similar comments
/build-ci |
/build-ci |
DejunL
force-pushed
the
dejunl/wdm-invoke
branch
from
December 6, 2024 23:58
45c8088
to
5654936
Compare
/build-ci |
@pstjohn CI failed due to esm2 tests:
|
/build-ci |
DejunL
force-pushed
the
dejunl/wdm-invoke
branch
from
December 9, 2024 16:31
5654936
to
53ca6e0
Compare
/build-ci |
CI still fails with:
|
These invocables are member functions of the webdataset or webloader class that return the the same instance their are invoked from. Previously webdatamodule does its own computation on the epoch length but now can rely on the user input directly using webdataset/webloader.with_epoch() due to this new additional feature
DejunL
force-pushed
the
dejunl/wdm-invoke
branch
from
December 9, 2024 21:15
53ca6e0
to
d58edab
Compare
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The webdataset invocables are member functions of the webdataset or webloader class that return the the same instance their are invoked from. Previously webdatamodule does its own computation on the epoch length but now can rely on the user input directly using
webdataset/webloader.with_epoch()
due to this new additional featureDetails
Describe your changes. You can be more detailed and descriptive here. If it is a code change, Be sure to answer:
(see the summary above)
These invocables are parts of the webdataset usage and we have been using them in diffdock to set up the epoch length and other properties of the dataset and dataloader objects.
(see the updated README.md regarding the
invoke_wds
andinvoke_wld
arguments on webdatamodule)Usage
How does a user interact with the changed code?
(see the updated README.md regarding the
invoke_wds
andinvoke_wld
arguments on webdatamodule)Testing
Tests for these changes can be run via:
Most of the changes to files with extensions
*.py
,*.yaml
,*.yml
,Dockerfile*
orrequirements.txt
DO REQUIRE bothpytest-
andjet-
CI stages.SKIP_CI
label to your PR?PYTEST_NOT_REQUIRED
label to your PR?JET_NOT_REQUIRED
label to your PR?