From b80952866313e35e680a2a1195d9febea2b6b186 Mon Sep 17 00:00:00 2001 From: Dorota Toczydlowska Date: Wed, 4 Dec 2024 16:02:21 +0000 Subject: [PATCH 1/2] changing source of data download in pytest to ngc --- ci/scripts/run_pytest.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/scripts/run_pytest.sh b/ci/scripts/run_pytest.sh index baff2677a..43a253b60 100755 --- a/ci/scripts/run_pytest.sh +++ b/ci/scripts/run_pytest.sh @@ -18,7 +18,7 @@ set -xueo pipefail export PYTHONDONTWRITEBYTECODE=1 # NOTE: if a non-nvidia user wants to run the test suite, just run `export BIONEMO_DATA_SOURCE=ngc` prior to this call. -export BIONEMO_DATA_SOURCE="${BIONEMO_DATA_SOURCE:-pbss}" +export BIONEMO_DATA_SOURCE="${BIONEMO_DATA_SOURCE:-ngc}" source "$(dirname "$0")/utils.sh" if ! set_bionemo_home; then From 7032a0caa2340dbe733591f27875c7c86aaae02d Mon Sep 17 00:00:00 2001 From: Dorota Toczydlowska Date: Wed, 4 Dec 2024 16:07:09 +0000 Subject: [PATCH 2/2] removing xfail test --- .../bionemo-core/tests/bionemo/core/data/test_load.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/sub-packages/bionemo-core/tests/bionemo/core/data/test_load.py b/sub-packages/bionemo-core/tests/bionemo/core/data/test_load.py index ee8146b5d..d0510a7db 100644 --- a/sub-packages/bionemo-core/tests/bionemo/core/data/test_load.py +++ b/sub-packages/bionemo-core/tests/bionemo/core/data/test_load.py @@ -23,7 +23,7 @@ import pytest -from bionemo.core.data.load import default_ngc_client, default_pbss_client, load +from bionemo.core.data.load import default_pbss_client, load from bionemo.core.data.resource import get_all_resources @@ -269,12 +269,6 @@ def test_default_pbss_client(): assert client.meta.endpoint_url == "https://pbss.s8k.io" -@pytest.mark.xfail(reason="Logging into NGC is not required to download artifacts in BioNeMo.") -def test_default_ngc_client(): - clt = default_ngc_client() - assert clt.api_key is not None - - @patch("bionemo.core.data.load.default_ngc_client") def test_load_with_file_from_ngc_model(mocked_get_ngc_client, tmp_path): (tmp_path / "foo.yaml").write_text(