Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfd-worker shocks on motherboard name #1074

Open
qdii opened this issue Oct 26, 2024 · 1 comment
Open

nfd-worker shocks on motherboard name #1074

qdii opened this issue Oct 26, 2024 · 1 comment

Comments

@qdii
Copy link

qdii commented Oct 26, 2024

Found that in the logs:

[nfd-worker.go:607] "ignoring label with invalid value" labelKey="nvidia.com/gpu.machine" labelValue="X9SRA/X9SRA-3" errors=["a valid label must be an empty string or consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9.]*)?[A-Za-z0-9])?')"]

Could you expand the regex?

@benhwebster
Copy link

That's a label requirement imposed by kubernetes, it might make sense to hash/drop invalid characters (or just don't generate labels containing invalid values), but that's up to the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants