Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building binaries, not just packages? #221

Open
deitch opened this issue Sep 13, 2023 · 2 comments
Open

Building binaries, not just packages? #221

deitch opened this issue Sep 13, 2023 · 2 comments

Comments

@deitch
Copy link

deitch commented Sep 13, 2023

Is there a way to build the binaries (executables and libraries), not just the deb or rpm, etc. packages? I dug into the Dockerfiles for centos and ubuntu, and both do their builds internally on scratch space, collecting just the .deb files for external consumption.

Can we include the binaries themselves? It is good that Dockerfile.centos uses CentOS to do a build, and also that it provides centos-compatible rpm packages, but it should be possible to get the binary artifacts themselves, not just the installation packages.

As it is, these already have to be built, so why not make them available?

@ubuntuyeah
Copy link

ubuntuyeah commented Oct 7, 2023

Just run make.

git clone https://github.com/NVIDIA/libnvidia-container.git --depth=1
cd libnvidia-container
sudo apt install golang bmake m4 libcap-dev
make  
cd deps/src/elftoolchain-0.7.1/libelf
cc -pipe -o libelf.so.1 -shared -Wl,--soname=libelf.so.1 -Wl,--whole-archive libelf_pic.a -Wl,--no-whole-archive
cd -
make
make install prefix=/usr/local

Or do you mean to just have a binary in the release directory? Problem with that is it will probably not run on a bunch of systems.

@deitch
Copy link
Author

deitch commented Oct 8, 2023

Actually, I rather like what you did (other than the apt install for dependencies, which assumes one is on apt-compatible system, but that can be abstracted away).

Can we add those to the instructions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants