Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix String tests on Databricks 14.3 #11535

Closed
razajafri opened this issue Sep 27, 2024 · 1 comment · Fixed by #11669
Closed

Fix String tests on Databricks 14.3 #11535

razajafri opened this issue Sep 27, 2024 · 1 comment · Fixed by #11669
Assignees
@mythrocks

Comments

@razajafri
Copy link
Collaborator

razajafri commented Sep 27, 2024 •
edited
Loading

Build the plugin against the Databricks 14.3 cluster using #11467. Once built successfully run the String tests by TESTS=string_test.py jenkins/databricks/test.sh

The following tests fail

[gw3] [ 95%] FAILED ../../src/main/python/string_test.py::test_startswith
@mythrocks mythrocks self-assigned this Oct 28, 2024
mythrocks added a commit to mythrocks/spark-rapids that referenced this issue Oct 28, 2024
@mythrocks
Fix string_test for [databricks] 14.3
7807452 
Fixes NVIDIA#11535.

This commit fixes the failure of `test_startswith`
and `test_endswith` in `string_test.py` on Databricks 14.3.

This is, in effect, a follow-on to the changes introduced in NVIDIA#11247,
where `test_endswith` was skipped for Databricks 4.0, on account of
https://issues.apache.org/jira/browse/SPARK-48995.  It appears that
that bug afflicts Databricks 14.3 as well.

This commit handles both `test_startswith` and `test_endswith` for
Databricks 14.3 and Apache Spark 4.0.

Signed-off-by: MithunR <[email protected]>
@mythrocks mythrocks mentioned this issue Oct 28, 2024
Merged
@mythrocks
Copy link
Collaborator

This failure should be addressed by #11669.

mythrocks added a commit that referenced this issue Nov 6, 2024
@mythrocks
Fix string_test for [databricks] 14.3 (#11669)
6100334 
* Fix string_test for [databricks] 14.3

Fixes #11535.

This commit fixes the failure of `test_startswith`
and `test_endswith` in `string_test.py` on Databricks 14.3.

This is, in effect, a follow-on to the changes introduced in #11247,
where `test_endswith` was skipped for Databricks 4.0, on account of
https://issues.apache.org/jira/browse/SPARK-48995.  It appears that
that bug afflicts Databricks 14.3 as well.

This commit handles both `test_startswith` and `test_endswith` for
Databricks 14.3 and Apache Spark 4.0.

Signed-off-by: MithunR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mythrocks mythrocks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix string_test for [databricks] 14.3 mythrocks/spark-rapids
2 participants
@mythrocks @razajafri