Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Look at switching algorithms on split and retry in aggregation #8432

Open
revans2 opened this issue May 30, 2023 · 0 comments
Open

[FEA] Look at switching algorithms on split and retry in aggregation #8432

revans2 opened this issue May 30, 2023 · 0 comments
Labels
feature request New feature or request reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented May 30, 2023

Is your feature request related to a problem? Please describe.
Aggregations are kind of complicated. We currently have a sort fallback, but that might change #8391

However the fallback to sort, or whatever is next, is based on the intermediate size getting larger than the target batch size. If the user configured the job incorrectly where there is not enough memory for a target batch size input to complete, then we might want to look at falling back to another algorithm sooner.

For example I have seen stack traces in some extreme tests where we try to concat batches together and cannot because we are out of memory. I think this is likely due to fragmentation, but the concat code does not have a split and retry handling. It probably should fall back to doing sort based aggregations instead.

This should not be that common, but I thought we should still have it as something we could do more to improve reliability.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels May 30, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Development

No branches or pull requests

2 participants