-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reserve allocation should be displayed when erroring due to lack of memory on startup #11282
base: branch-24.10
Are you sure you want to change the base?
Conversation
…emory on startup Signed-off-by: Kuhu Shukla <[email protected]>
s"the minimum allocation of ${toMB(minAllocation)} (calculated from " + | ||
s"${RapidsConf.RMM_ALLOC_MIN_FRACTION} (=${conf.rmmAllocMinFraction}) " + | ||
s"and ${toMB(info.total)} MB total memory)") | ||
s"${toMB(poolAllocation)} MiB (gpu.free: ${toMB(info.free)}," + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rename toMB
to toMiB
(nit pick)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed but left it out to be conservative. Will update
s"${RapidsConf.RMM_ALLOC_FRACTION}: (=${conf.rmmAllocFraction}," + | ||
s"${RapidsConf.RMM_ALLOC_RESERVE}: ${reserveAmount} => " + | ||
s"(gpu.free - reserve) * allocFraction = ${toMB(poolAllocation)})" + | ||
s"was less than allocation of ${toMB(minAllocation)} MiB (gpu.total: " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can bring this message into two: the part before "was less than" and the part after. That way we can reuse it in the second case (it is almost verbatim except for this text, as far as I can tell).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
Signed-off-by: Kuhu Shukla <[email protected]>
@abellina I think this is pretty close, whenever you have a chance to take a look. Thank u! |
build |
Fixes #11168
I think using
is the right decision here but I would like for someone to correct or confirm.
I don't have a test for this. Can look into it if preferred for the review.