Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with some artifacts #6

Open
trsh opened this issue Nov 7, 2022 · 9 comments
Open

Dealing with some artifacts #6

trsh opened this issue Nov 7, 2022 · 9 comments

Comments

@trsh
Copy link

trsh commented Nov 7, 2022

Dear nvidia, do you have any idea or advice, on what would cause the ugly line on the front box?

2022-11-07_103847

@abernalnv
Copy link
Collaborator

can you try NIS_CLAMP_OUTPUT = 1 in your defines? Also try to use a bit less sharpness
Are you using NIS with HDR?

@trsh
Copy link
Author

trsh commented Nov 7, 2022

can you try NIS_CLAMP_OUTPUT = 1 in your defines? Also try to use a bit less sharpness Are you using NIS with HDR?

NIS_CLAMP_OUTPUT did not make a difference. HDR is = NISHDRMode::None. Sharpness can be 0, and same line.

@trsh
Copy link
Author

trsh commented Nov 7, 2022

2022-11-07_105755
Sharpness 0 + NIS_CLAMP_OUTPUT

@abernalnv
Copy link
Collaborator

What is the scale ratio?
Do you have an image that we can use for debugging?

@trsh
Copy link
Author

trsh commented Nov 7, 2022

in_x = 640
in_y = 360
out_x = 1280
out_y = 720

This should be the texture, that is upscaled

before_upsc

@abernalnv
Copy link
Collaborator

@trsh, Thank you Janis. We'll take a look.

@trsh
Copy link
Author

trsh commented Dec 2, 2022

Anything new around this?

@abernalnv
Copy link
Collaborator

@trsh. We have not being able to repro the strong artifacts on the lines, but we observed some overshooting on the edges specially with large sharpness values. The image is already very sharp and applying sharpening on top can result on overshooting. We're investigating using a different detection ratio as well as an attenuated LTI function that might help with this specific case.

@trsh
Copy link
Author

trsh commented Dec 5, 2022

Strange that you were not able to reproduce. Then it should be something off with my setup!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants