-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyTorch #19
Comments
We are not planning implementing it for now, but some people are indeed suggesting that pyTorch may be faster than TF. It would be great if someone can implement GA3C in pyTorch following our guidelines. |
I did a quick trial in one of my branches . Actually, TF is almost twice as fast, because the naive way I did the vectorized loss is probably involving a lot of function calls. The same issue arises for Chainer version. The loss takes almost more time to compute than the cnn. I think it could work faster if implementing it as a specific layer. |
Just FYI, my friend was able to reproduce both the speed and performance of my a3c implementation with his pytorch code. |
interesting @ppwwyyxx ! I am not sure if the problem is in the batching, rather than the explicit calls & many steps of computation for the loss.
If someone knows how to do this more quickly in pytorch ...? |
@ppwwyyxx Is there a public git repo for your friend's pyTorch implementation ? |
Unfortunately no.. |
Isn't there any plan on the horizon to port this code to pyTorch ?
The text was updated successfully, but these errors were encountered: