From e06d5282058bd31dcb84d4ef54774bcff5b847f7 Mon Sep 17 00:00:00 2001 From: Anatol Coen Date: Sun, 19 May 2024 22:54:16 +1200 Subject: [PATCH] Fix error when submission source is nil --- app/controllers/problems_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/problems_controller.rb b/app/controllers/problems_controller.rb index 02f09b60..8264f648 100644 --- a/app/controllers/problems_controller.rb +++ b/app/controllers/problems_controller.rb @@ -87,7 +87,7 @@ def submit @problem = Problem.find(params[:id]) @submission = Submission.new(submit_params) # create submission respond_to do |format| - source_is_valid = @submission.source.valid_encoding? && !@submission.source.include?("\0") + source_is_valid = @submission.source.nil? || @submission.source.valid_encoding? && !@submission.source.include?("\0") if !source_is_valid @submission.errors.add :source_file, "has an invalid text encoding. This was likely caused by submitting a compiled file (.exe, .out, .class, ...) instead of a source code file (.cpp, .c, .java, ...)." @submission.source = nil; # Prevent submission form from trying to render the source (and erroring)