Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

School country code to be redundant #133

Open
puqeko opened this issue Feb 16, 2021 · 0 comments
Open

School country code to be redundant #133

puqeko opened this issue Feb 16, 2021 · 0 comments

Comments

@puqeko
Copy link
Member

puqeko commented Feb 16, 2021

Following #125 and as mentioned in #128. All schools now in the database should be NZ schools. However, statements such as School.where(country_code: "NZ") will not work if this field is set to nil or removed from the database.

Suggested tasks:

  • Remove country code field from registration form.
  • Remove country code from database and create migration.
  • Ensure that all mentions of School.where(country_code: "NZ") are replaced across the site.
@puqeko puqeko changed the title School country code now redundant School country code to be redundant Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant