Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation check to loop_in_chunks #2028

Closed
stevengj opened this issue Mar 31, 2022 · 0 comments · Fixed by #2040
Closed

add validation check to loop_in_chunks #2028

stevengj opened this issue Mar 31, 2022 · 0 comments · Fixed by #2040

Comments

@stevengj
Copy link
Collaborator

stevengj commented Mar 31, 2022

For things like #1895, it might be good to add a validation check to the loop_in_chunks code: as we loop over the chunks, keep a running sum of the total number of grid points in all of the chunkloop calls, and then check at the end that this total equals the number of points in the original volume. (If not, emit a warning.)

I think this should be cheap, so it wouldn't hurt to do it all the time. But if we want we could only enable it in --enable-debug mode.

cc @mochen4, @mawc2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant