Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Workflow Secrets not being applied #15

Closed
receronp opened this issue May 27, 2023 · 3 comments
Closed

Github Workflow Secrets not being applied #15

receronp opened this issue May 27, 2023 · 3 comments

Comments

@receronp
Copy link

receronp commented May 27, 2023

@tomijaga I am seeing the following error when my PR tries to run the Workflow tests.

  echo "" > ./identity.pem
  echo ""
  dfx identity import icrc-ref-test ./identity.pem --storage-mode plaintext
  dfx identity use icrc-ref-test
  dfx identity whoami
  make ref-test
  shell: /usr/bin/bash -e {0}
  env:
    DFX_TELEMETRY_DISABLED: 1

ref-test

Is there some config I am missing to enable secrets for this PR?
I see in the makefile that this is the one trying to be called:

echo "${{ secrets.IDENTITY_SSH }}" > ./identity.pem

I leave the action link below:
https://github.com/NatLabs/icrc1/actions/runs/5099151687/jobs/9166723292

@tomijaga
Copy link
Member

Hello @receronp, thanks for the info.
Unfortunately, the settings you provided are only applicable for private repos.
I'm working on granting external PRs access to secrets using the pull_request_target event mentioned in the GitHub issue at the end of your post.
I'll let you know when I've pushed a fix to the main branch.

@tomijaga
Copy link
Member

Hey @receronp,
I've pushed the fix to the main branch, so the workflow tests should work once you've merged the new changes to the pr branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants