Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP Restriction plugin: support range IP format #264

Open
gmile opened this issue Sep 19, 2017 · 1 comment
Open

IP Restriction plugin: support range IP format #264

gmile opened this issue Sep 19, 2017 · 1 comment

Comments

@gmile
Copy link
Contributor

gmile commented Sep 19, 2017 •
edited
Loading

It would be useful to support IP format with network mask like this:

  • 103.21.244.0/22
  • 103.22.200.0/22
  • 103.31.4.0/22
  • 104.16.0.0/12
  • 108.162.192.0/18
@gmile
Copy link
Contributor Author

gmile commented Sep 20, 2017 •
edited
Loading

@AndrewDryga this was done in a fork, edenlabllc#3. Maybe it can get merged upstream too? Here's the patch you can apply manually: https://github.com/edenlabllc/annon.api/pull/3.patch

I stumbled upon the fact that we supported 127.0.*.1 format. I didn't rip it off. But I think mask format will cover the case when someone wants to provide a range of IPs. Also, mask format is used in kong – https://getkong.org/plugins/ip-restriction/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmile