Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMGX CONFIG FILE is not properly passed #521

Open
yslan opened this issue Sep 6, 2023 · 0 comments
Open

AMGX CONFIG FILE is not properly passed #521

yslan opened this issue Sep 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@yslan
Copy link
Contributor

yslan commented Sep 6, 2023

Describe the bug
It appears that we don't pass the "AMGX CONFIG FILE" to solver->options so it's not using the user specified "amgx.json".

To Reproduce
In par file

[PRESSURE]
coarseSolver = amgx+device

[AMGX]
configFile = "amgx.json"

In the file src/solvers/elliptic/MG/coarseLevel.cpp, print the following

    std::string configFile;
    options.getArgs("AMGX CONFIG FILE", configFile); 
    std::string configFile2;
    platform->options.getArgs("AMGX CONFIG FILE", configFile2);

    if(platform->comm.mpiRank == 0) {
      std::cout << "\n ttt AMGX_CONFIG "<< configFile << "\n" << std::endl;  // This is empty
      std::cout << "\n ttt AMGX_CONFIG 2"<< configFile2 << "\n" << std::endl;  // This has the correct file
    }

Expected behavior
I think it will be nice to make AMG setup more verbose.
I propose to print AMGX solver config options in solvers/elliptic/amgSolver/amgx/AMGX.cpp
or calling something equivalent from AMGX to confirm the amgx.json is indeed used.

Desktop (please complete the following information):

  • OS: Run and tested on Summit
  • Version: v23

Credit to @yhmtsai who found this.

@stgeke stgeke added the bug Something isn't working label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants