Add Base.keys(::MatElem)
#1906
Merged
Add Base.keys(::MatElem)
#1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1906 +/- ##
=======================================
Coverage 88.16% 88.17%
=======================================
Files 120 120
Lines 30296 30297 +1
=======================================
+ Hits 26711 26714 +3
+ Misses 3585 3583 -2 ☔ View full report in Codecov by Sentry. |
fingolfin
reviewed
Nov 15, 2024
| @@ -567,6 +567,7 @@ end | |||
|
|
|||
| Base.IteratorSize(::Type{<:MatrixElem}) = Base.HasShape{2}() | |||
|
|
|||
| Base.keys(M::MatElem) = CartesianIndices(axes(M)) | |||
There was a problem hiding this comment.
could you add a simple test exercising this?
fingolfin
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to e.g. do a
findall(f, ::MatElem)in julia 1.10, and thus is needed for the 1.10 tests on oscar-system/Oscar.jl#4322.