Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nadirpinhole not properly set in camera_solve with camera positions. #248

Open
ScottMcMichael opened this issue Mar 20, 2019 · 2 comments
Open

Comments

@ScottMcMichael
Copy link
Contributor

When --camera-positions is passed in to camera_solve it should automatically use the session "nadirpinhole" but this is not working properly.

@oleg-alexandrov
Copy link
Member

Good point. This would assume we are on Earth though, which I guess it is reasonable since we don't play with frame cameras on other planets.

There is also the issue if bundle_adjust assumes a datum when it does the first adjustment, while the cameras are still in an arbitrary coordinate system. Maybe camera_solve should invoke bundle_adjust with the --no-datum flag.

@ScottMcMichael
Copy link
Contributor Author

I was not able to reproduce this error so it may take extra investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants