Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming convention of configuration parameters for better readability #1554

Open
D00mch opened this issue Nov 10, 2024 · 4 comments
Open

Comments

@D00mch
Copy link
Contributor

D00mch commented Nov 10, 2024

I'd like to suggest re-evaluating the naming convention for certain configuration parameters. Currently, the parameters use "disable" as a prefix, which increases cognitive load when interpreting their values.

“disable_*=false“ is like a negation of negation (two operation to get the meaning).

Using an “enable_*“ prefix would make it more intuitive and easy to get.

Parameters:

disable_context_highlighting
disable_hint
disable_insert_on_commit 
disable_line_numbers
disable_signs
@CKolkey
Copy link
Member

CKolkey commented Nov 10, 2024

Totally agreed - these are just kinda legacy from before I took over. I'm open to changing them, but won't have time for a while. I brought twins home from the hospital juuuuust a few hours ago 😅

So, if you wanna do it, be my guest. Otherwise... no worries, it'll be a minute though.

@D00mch
Copy link
Contributor Author

D00mch commented Nov 10, 2024

I will make a PR today

@ktsujister
Copy link

This seems like it's related to #227 as well.

@D00mch
Copy link
Contributor Author

D00mch commented Dec 7, 2024

Updated the PR, merged conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants