Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neogit not working in Ubuntu 20.04 #1627

Closed
villapx-path opened this issue Jan 10, 2025 · 2 comments
Closed

Neogit not working in Ubuntu 20.04 #1627

villapx-path opened this issue Jan 10, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@villapx-path
Copy link

Description

As the title states, Neogit is not working in Ubuntu 20.04 / Focal. Specifically:

  • When I run simply :Neogit, it is unable to detect that the current directory (:pwd) is within a git repository, and it prompts me, Initialize repository in <path> --path-format=absolute? (Y)es, [No]:.
  • When I specify a specific directory, i.e. :Neogit cwd=<dir>, it prints this error:
    Error executing Lua callback: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: Vim:E475: Invalid argument: expected valid directory
    stack traceback:
            [C]: in function 'error'
            ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
            ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'step'
            ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:48: in function 'execute'
            ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:118: in function 'dispatch_refresh'
            /home/jvilla/.local/share/nvim/lazy/neogit/lua/neogit.lua:114: in function 'open_status_buffer'
            /home/jvilla/.local/share/nvim/lazy/neogit/lua/neogit.lua:175: in function 'open'
            ...e/jvilla/.local/share/nvim/lazy/neogit/plugin/neogit.lua:5: in function <...e/jvilla/.local/share/nvim/lazy/neogit/plugin/neogit.lua:3>
    Press ENTER or type command to continue
    

I have already posted an issue with plenary.nvim, and the maintainer determined that it is not a plenary bug, so I'm wondering now if there's something wrong that Neogit is doing.

Please let me know any additional debug steps I can take. Thanks in advance!!


(I realize that Ubuntu 20.04 is almost EOL for general support, but my company will still be using it for the foreseeable future, so I would love to figure this out so I can keep enjoying Neogit like I do on my other machines 😄)

Neovim version

NVIM v0.10.3
Build type: Release
LuaJIT 2.1.1713484068

Operating system and version

Ubuntu 20.04

Steps to reproduce

  1. Initialize new git repo, open neovim with minimal config, with pwd inside the repo
    mkdir /tmp/foobar
    cd /tmp/foobar
    git init
    nvim -nu /tmp/minimal.lua
    
  2. Once in neovim, run command: :Neogit
  3. Observe error:
    :Neogit
    Initialize repository in /tmp/foobar
    --path-format=absolute?
    (Y)es, [N]o:
    

Expected behavior

Expected the "main" Neogit screen to open

Actual behavior

Prompted to initialize a new git repository in pwd:

Initialize repository in /tmp/foobar
--path-format=absolute?
(Y)es, [N]o:

Selecting [N]o returns the error The current working directory is not a git repository;

Selecting (Y)es prints the following error:

Error executing Lua callback: /tmp/.min/plugins/plenary/lua/plenary/async/async.lua:18: The coroutine failed with this message: /tmp/.min/plugins/plenary/lua/plenary/async/async.lua:18: The coroutine failed with this message: Vim:E475: Invalid argument: expected valid directory
stack traceback:
        [C]: in function 'error'
        /tmp/.min/plugins/plenary/lua/plenary/async/async.lua:18: in function 'callback_or_next'
        /tmp/.min/plugins/plenary/lua/plenary/async/async.lua:45: in function 'step'
        /tmp/.min/plugins/plenary/lua/plenary/async/async.lua:48: in function 'execute'
        /tmp/.min/plugins/plenary/lua/plenary/async/async.lua:118: in function 'dispatch_refresh'
        /tmp/.min/plugins/neogit/lua/neogit/lib/git/repository.lua:200: in function '__index'
        /tmp/.min/plugins/neogit/lua/neogit/lib/git/cli.lua:1184: in function 'to_process'
        /tmp/.min/plugins/neogit/lua/neogit/lib/git/cli.lua:1242: in function 'call'
        /tmp/.min/plugins/neogit/lua/neogit/lib/git/init.lua:9: in function 'create'
        /tmp/.min/plugins/neogit/lua/neogit.lua:158: in function 'open'
        /tmp/.min/plugins/neogit/plugin/neogit.lua:5: in function </tmp/.min/plugins/neogit/plugin/neogit.lua:3>

Minimal config

-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit
@villapx-path villapx-path added the bug Something isn't working label Jan 10, 2025
@SheffeyG
Copy link
Contributor

It's the same issue here #1624

@CKolkey
Copy link
Member

CKolkey commented Jan 14, 2025

Closing this as it's a duplicate of #1624

@CKolkey CKolkey closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants