From 27edaa5c1bec612f55cddceb11254f4e92fdc07f Mon Sep 17 00:00:00 2001 From: Daniel McKnight <34697904+NeonDaniel@users.noreply.github.com> Date: Mon, 26 Feb 2024 11:58:33 -0800 Subject: [PATCH] Remove completed TODO comments (#13) Add release notes to GHA Co-authored-by: Daniel McKnight --- .github/workflows/publish_release.yml | 1 + neon_hana/schema/api_requests.py | 4 ++-- neon_hana/schema/assist_requests.py | 2 -- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish_release.yml b/.github/workflows/publish_release.yml index 2cd2be9..bb42ad0 100644 --- a/.github/workflows/publish_release.yml +++ b/.github/workflows/publish_release.yml @@ -19,6 +19,7 @@ jobs: with: token: ${{secrets.GITHUB_TOKEN}} tag: ${{env.VERSION}} + generateReleaseNotes: true build_and_publish_docker: uses: neongeckocom/.github/.github/workflows/publish_docker.yml@master secrets: inherit \ No newline at end of file diff --git a/neon_hana/schema/api_requests.py b/neon_hana/schema/api_requests.py index 092049d..3d652b8 100644 --- a/neon_hana/schema/api_requests.py +++ b/neon_hana/schema/api_requests.py @@ -198,11 +198,11 @@ class ParseScriptRequest(BaseModel): "no_val_1": Execute: what time is it -Python: 1*2 # TODO: syntax check +Python: 1*2 LOOP check START Set: new_val = no_val # This logs an error because it isn't declared -# TODO: The following should warn/error +# The following should warn/error dne = "test" voice_input(new_val) LOOP check END diff --git a/neon_hana/schema/assist_requests.py b/neon_hana/schema/assist_requests.py index 9cd66c4..7af09b7 100644 --- a/neon_hana/schema/assist_requests.py +++ b/neon_hana/schema/assist_requests.py @@ -78,8 +78,6 @@ class TTSResponse(BaseModel): }]}} -# TODO: User profile model with below inputs? - class SkillRequest(BaseModel): utterance: str lang_code: str