Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule to check for nodes below /libs #8

Closed
kwin opened this issue Feb 8, 2021 · 1 comment · Fixed by #10
Closed

Add rule to check for nodes below /libs #8

kwin opened this issue Feb 8, 2021 · 1 comment · Fixed by #10
Assignees
@kwin
Milestone
1.2.0

Comments

@kwin
Copy link
Member

kwin commented Feb 8, 2021 •
edited
Loading

Packages containing nodes below /libs are not allowed to be deployed in Cloud Manager.
A rule enforcing this should be added.
It needs to be configurable though, to be also usable e.g. for Core WCM Components which is part of the product (i.e. is allowed in /libs).

You must not make changes in the /libs branch
Any changes you do make may be lost, because this branch is liable to changes whenever upgrades are applied to your instance.

(https://experienceleague.adobe.com/docs/experience-manager-cloud-service/implementing/developing/full-stack/overlays.html?lang=en#developing)
@kwin kwin self-assigned this Feb 10, 2021
kwin added a commit that referenced this issue Feb 10, 2021
@kwin
Prevent libs nodes in packages
dcf0522 
This closes #8
@kwin kwin mentioned this issue Feb 10, 2021
Merged
kwin added a commit that referenced this issue Feb 10, 2021
@kwin
Prevent libs nodes in packages
ae2ae96 
This closes #8
@kwin
Copy link
Member Author

kwin commented Mar 4, 2021

This is not yet enforced in the Cloud Manager.

@kwin kwin closed this as completed in #10 Mar 18, 2021
kwin added a commit that referenced this issue Mar 18, 2021
@kwin
Prevent libs nodes in packages (#10)
07faa9f 
This closes #8
@kwin kwin added this to the 1.2.0 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwin kwin

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Prevent libs nodes in packages Netcentric/aem-cloud-validator
1 participant
@kwin