Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json-ifying string with newlines in it creates invalid JSON #492

Open
akhaku opened this issue Nov 12, 2020 · 2 comments
Open

Json-ifying string with newlines in it creates invalid JSON #492

akhaku opened this issue Nov 12, 2020 · 2 comments

Comments

@akhaku
Copy link
Contributor

akhaku commented Nov 12, 2020

No description provided.

@yalinhuang
Copy link

We ran into another similar issue due to special characters not escaped in HollowRecordJsonStringifier.stringify() -- it's a tab character ('\t'). Despite that such characters might not make any valuable meaning to the data and should be sanitized before passing down to Cinder, it'd be nice that the HollowRecordJsonStringifier.stringify() can handle general data values.

@nayanika-u
Copy link
Contributor

Hi @yalinhuang, looking into this one.

clay-mayers added a commit to clay-mayers/hollow that referenced this issue Mar 11, 2024
@clay-mayers
Fix: Escape control chars when stringifing JSON (Netflix#492)
a11ff94
clay-mayers added a commit to clay-mayers/hollow that referenced this issue Mar 11, 2024
@clay-mayers
Fix: V2 Escape control chars when stringifing JSON (Netflix#492)
c96faa7 
Only process a single character at a time - Processing 4 at at
a time has more repeatable timing but on average is slower.

Processing an unescaped string can be faster than the original
method of find/find.
clay-mayers added a commit to clay-mayers/hollow that referenced this issue Mar 12, 2024
@clay-mayers
Fix: V3 Escape control chars when stringifing JSON (Netflix#492)
b4a080d 
Properly handle UTF-16
clay-mayers added a commit to clay-mayers/hollow that referenced this issue Mar 21, 2024
@clay-mayers
Fix: Escape control chars when stringifing JSON (Netflix#492)
b673346
clay-mayers added a commit to clay-mayers/hollow that referenced this issue Mar 21, 2024
@clay-mayers
Fix: Escape control chars when stringifing JSON (Netflix#492)
7783973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akhaku @yalinhuang @nayanika-u