Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError in Runner async_run and async_resume #2034

Closed
filipcacky opened this issue Sep 17, 2024 · 1 comment
Closed

AttributeError in Runner async_run and async_resume #2034

filipcacky opened this issue Sep 17, 2024 · 1 comment

Comments

@filipcacky
Copy link

filipcacky commented Sep 17, 2024

The async methods async_run and async_resume in Runner call __get_executing_run and read_from_file_when_ready, which uses poll on CommandManager.process here . Since asyncio.Process created here doesn’t implement poll (see docs), unlike subprocess.Popen from here used in the sync methods, this results in an AttributeError.

@madhur-ob
Copy link
Collaborator

Closing this since this is already addressed..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants