Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove netflix commons #519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove netflix commons #519

wants to merge 1 commit into from

Conversation

joshgord
Copy link

Forklift what we use out of netflix commons and remove the dependency. For whatever reason it looks like commons has fallen into disrepair and doesn't appear to be actively maintained

* limitations under the License.
*
*/
package com.netflix.stats.distribution;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the same classes here and in netflix-common libs could create problems if both wind up in the classpath. Could the package be changed to avoid possible conflicts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, hopefully no one is using netflix-commons directly

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to a package prefixed with internal., open to naming of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants