Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies out of date #1

Open
davidgruar opened this issue May 2, 2018 · 2 comments
Open

Peer dependencies out of date #1

davidgruar opened this issue May 2, 2018 · 2 comments

Comments

@davidgruar
Copy link

These peer dependencies are specified:

"peerDependencies": {
        "stylelint": "^8.3.0",
        "stylelint-scss": "^2.0.0",
        "stylelint-order": "^0.8.0"
    }

stylelint is currently at 9.2.0, and stylelint-scss at 3.1.0, so if you install the latest versions into a new project you still get warnings about missing peer dependencies.

Should we specify acceptable ranges, i.e. ^8.3.0-^9.2.0 and ^2.0.0-^3.1.0, respectively? Or just require the latest major version? @Jameskmonger, @OwenPattison, what do you think?

@OwenPattison
Copy link
Contributor

I think we should probably be using the latest version. @jamesadarich can likely weigh in on this too

@jamesadarich
Copy link
Contributor

@davidgruar @OwenPattison sorry about late reply on this one.

Generally with configuration like this the major version will represent a breaking change in the configuration file itself and is unlikely to be fully compatible across mutliple major versions.

For things like this I'd usually pin it to a major version e.g. ^8.0.0 and if someone requires backwards compatibility then they use an older version of this package. Therefore every time the peer jumps up a major version so should this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants