Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create / improve component tests for components that use AudioContext #36

Open
1 task
tiagosousagarcia opened this issue Jun 27, 2023 · 0 comments
Open
1 task
Labels
documentation Improvements or additions to documentation enhancement New feature or request testing issues relating to unit, component, or E2E testing view: music relating to the music view wontfix This will not be worked on

Comments

@tiagosousagarcia
Copy link
Collaborator

Summary

Testing components that use AudioContext almost invariably throw errors because AudioContext is not emulated by jsdom. There are ways around it (such as using standardized-audio-context-mock) but they don't cover all use cases, and I would need to manually mock every AudioContext function. Parking this for now as the basic testing of these components can be covered in E2E testing and it's not a good use of time to invest in properly creating a test suite for these components (which are likely to change) at this time.

What needs to be done?

  • Mock AudioContext manually, or find a library that does that more comprehensibly than standardized-audio-context-mock

Updates

@tiagosousagarcia tiagosousagarcia added documentation Improvements or additions to documentation enhancement New feature or request wontfix This will not be worked on view: music relating to the music view testing issues relating to unit, component, or E2E testing labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request testing issues relating to unit, component, or E2E testing view: music relating to the music view wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant