리워드 홈 배너 및 팝업 기능 추가 #114
Merged
리워드 홈 배너 및 팝업 기능 추가 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nohjunh
commented
Jul 24, 2024
nohjunh
commented
- 홈화면에 카카오 공유하기 버튼 추가 (divider deco 제거)
- 비로그인 상태에서 보이는 리워드 배너 추가
- 로그인 상태에서 보이는 리워드 팝업 추가
- 프리텐다드 negative space로 인한 타이머 좌우 움직임 해결을 위해 타이머 부분에만 프리텐다드 제거
| rewardRepository.getHomeRewardBanner() | ||
| .shareIn( | ||
| scope = viewModelScope, | ||
| started = SharingStarted.WhileSubscribed(1000L), |
There was a problem hiding this comment.
[질문]
여기에 WhileSubscribed를 주어야 하는 이유가 있는거야?? (궁금)
There was a problem hiding this comment.
HomeScreen에 진입했을 때 수집하고 다른 화면으로 이동했을 때는 수집을 중지하기 위함이라고 생각했어!
There was a problem hiding this comment.
이 플로우를 구독하고 있는 곳(fragment)에서
flowWithLifecycle(viewLifecycleOwner.lifecycle, Lifecycle.State.STARTED) 하고 있으니까
화면 이동할때(onStop)는 collect가 중단되지 않아?
(= WhileSubscribed가 굳이 필요 없을 것 같다는 뜻)
...c/main/kotlin/com/silvertown/android/dailyphrase/domain/usecase/GetHomeRewardStateUseCase.kt
Outdated
Show resolved
Hide resolved
data/src/main/kotlin/com/silvertown/android/dailyphrase/data/repository/MemberRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
|
이거 바로 develop에 넣지 말구 내꺼까지 /reward에 들어가면 그때 develop에 넣자! |
|
응모하고 xx 받기나 그래야 이거 머지되면 내가 safeNavigate만 작성해서 바로 동작하게 할 수 있을 것 같아! |
.../src/main/kotlin/com/silvertown/android/dailyphrase/data/network/service/RewardApiService.kt
Outdated
Show resolved
Hide resolved
...tlin/com/silvertown/android/dailyphrase/data/network/model/response/RewardWrapperResponse.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/com/silvertown/android/dailyphrase/data/network/model/response/RewardResponse.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/silvertown/android/dailyphrase/data/network/model/response/RewardInfoResponse.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.