From 3e57cd7f53f4a07602125e891977378a153395aa Mon Sep 17 00:00:00 2001
From: elshenak <elshenak@gmail.com>
Date: Sun, 29 Oct 2023 14:32:37 -0400
Subject: [PATCH] fix: sonar bugs

---
 src/components/dynamic/ObjectElement.vue           |  2 ++
 src/components/dynamic/TxsElement.vue              |  1 +
 src/layouts/components/ChainProfile.vue            |  2 +-
 src/layouts/components/DefaultLayout.vue           |  5 +++++
 src/layouts/components/NavFooter.vue               |  2 +-
 src/modules/[chain]/account/[address].vue          |  3 +++
 src/modules/[chain]/account/index.vue              |  2 ++
 src/modules/[chain]/block/[height].vue             |  2 ++
 src/modules/[chain]/block/index.vue                |  1 +
 .../[chain]/cosmwasm/[code_id]/contracts.vue       |  1 +
 .../[chain]/cosmwasm/[code_id]/transactions.vue    |  4 ++++
 src/modules/[chain]/cosmwasm/index.vue             |  1 +
 src/modules/[chain]/gov/[proposal_id].vue          |  2 ++
 .../[chain]/ibc/connection/[connection_id].vue     | 14 ++++++++------
 src/modules/[chain]/staking/[validator].vue        |  3 +++
 src/modules/[chain]/staking/index.vue              |  2 ++
 16 files changed, 39 insertions(+), 8 deletions(-)

diff --git a/src/components/dynamic/ObjectElement.vue b/src/components/dynamic/ObjectElement.vue
index 008537df9d..36c1f3f6ca 100644
--- a/src/components/dynamic/ObjectElement.vue
+++ b/src/components/dynamic/ObjectElement.vue
@@ -6,6 +6,8 @@ const props = defineProps(['value']);
 <template>
   <div class="overflow-auto">
     <table class="table table-compact w-full text-sm">
+      <caption class="hidden">List Table</caption>
+      <th class="hidden"></th>
       <tbody>
         <tr v-for="(v, k) of value">
           <td
diff --git a/src/components/dynamic/TxsElement.vue b/src/components/dynamic/TxsElement.vue
index d90acd04c1..5b86b2141c 100644
--- a/src/components/dynamic/TxsElement.vue
+++ b/src/components/dynamic/TxsElement.vue
@@ -21,6 +21,7 @@ const chain = useBlockchain();
 <template>
   <div class="overflow-x-auto mt-4">
     <table class="table w-full" density="compact" v-if="txs.length > 0">
+      <caption class="hidden">Txs</caption>
       <thead>
         <tr>
           <th style="position: relative; z-index: 2;">Hash</th>
diff --git a/src/layouts/components/ChainProfile.vue b/src/layouts/components/ChainProfile.vue
index 67736286f4..3f7a281c82 100644
--- a/src/layouts/components/ChainProfile.vue
+++ b/src/layouts/components/ChainProfile.vue
@@ -15,7 +15,7 @@ function changeEndpoint(item: Endpoint) {
   <div class="dropdown">
     <label tabindex="0" class="flex items-center">
       <div class="p-1 relative mr-3 cursor-pointer">
-        <img v-lazy="chainStore.logo" class="w-9 h-9 rounded-full" />
+        <img v-lazy="chainStore.logo" class="w-9 h-9 rounded-full" alt="chainstore-logo"/>
         <div
           class="w-2 h-2 rounded-full bg-yes absolute right-0 bottom-0 shadow"
         ></div>
diff --git a/src/layouts/components/DefaultLayout.vue b/src/layouts/components/DefaultLayout.vue
index 2b6f79a014..78510e7ba7 100644
--- a/src/layouts/components/DefaultLayout.vue
+++ b/src/layouts/components/DefaultLayout.vue
@@ -112,6 +112,7 @@ function selected(route: any, nav: NavLink) {
               v-if="item?.icon?.image"
               :src="item?.icon?.image"
               class="w-6 h-6 rounded-full mr-3"
+              alt="icon"
             />
             <div
               class="text-base capitalize flex-1 text-gray-700 dark:text-gray-200 whitespace-nowrap"
@@ -150,6 +151,7 @@ function selected(route: any, nav: NavLink) {
                 <img
                   v-if="el?.icon?.image"
                   :src="el?.icon?.image"
+                  alt="el-icon"
                   class="w-6 h-6 rounded-full mr-3 ml-4 " :class="{
                   'border border-gray-300 bg-white': selected($route, el),
                 }"
@@ -186,6 +188,7 @@ function selected(route: any, nav: NavLink) {
             v-if="item?.icon?.image"
             :src="item?.icon?.image"
             class="w-6 h-6 rounded-full mr-3 border border-blue-100"
+            alt="listed-icon"
           />
           <div
             class="text-base capitalize flex-1 text-gray-700 dark:text-gray-200 whitespace-nowrap"
@@ -219,6 +222,7 @@ function selected(route: any, nav: NavLink) {
         >
           <img
             src="https://ping.pub/logos/osmosis.jpg"
+            alt="osmosis-logo"
             class="w-6 h-6 rounded-full mr-3"
           />
           <div
@@ -235,6 +239,7 @@ function selected(route: any, nav: NavLink) {
         >
           <img
             src="https://becole.com/static/logo/logo_becole.png"
+            alt="becole-logo"
             class="w-6 h-6 rounded-full mr-3"
           />
           <div
diff --git a/src/layouts/components/NavFooter.vue b/src/layouts/components/NavFooter.vue
index babc284e1a..19877b3078 100644
--- a/src/layouts/components/NavFooter.vue
+++ b/src/layouts/components/NavFooter.vue
@@ -7,7 +7,7 @@
       &copy;&nbsp;
       {{ new Date().getFullYear() }}&nbsp;
       Made With&nbsp;
-      <img src="../../assets/images/heart.svg" />&nbsp;
+      <img alt="footer-logo" src="../../assets/images/heart.svg" />&nbsp;
       By&nbsp;
       <a
         class="link link-primary no-underline"
diff --git a/src/modules/[chain]/account/[address].vue b/src/modules/[chain]/account/[address].vue
index 269d8ca609..f15d336506 100644
--- a/src/modules/[chain]/account/[address].vue
+++ b/src/modules/[chain]/account/[address].vue
@@ -346,6 +346,7 @@ function updateEvent() {
       </div>
       <div class="overflow-x-auto">
         <table class="table w-full text-sm table-zebra">
+          <caption class="hidden">Rewards</caption>
           <thead>
             <tr>
               <th class="py-3">{{ $t('account.validator') }}</th>
@@ -438,6 +439,7 @@ function updateEvent() {
       <h2 class="card-title mb-4">{{ $t('account.unbonding_delegations') }}</h2>
       <div class="overflow-x-auto">
         <table class="table text-sm w-full">
+          <caption class="hidden">unbounding Delegations</caption>
           <thead>
             <tr>
               <th class="py-3">{{ $t('account.creation_height') }}</th>
@@ -497,6 +499,7 @@ function updateEvent() {
       <h2 class="card-title mb-4">{{ $t('account.transactions') }}</h2>
       <div class="overflow-x-auto">
         <table class="table w-full text-sm">
+          <caption class="hidden">Transactions</caption>
           <thead>
             <tr>
               <th class="py-3">{{ $t('account.height') }}</th>
diff --git a/src/modules/[chain]/account/index.vue b/src/modules/[chain]/account/index.vue
index fe1ecb0815..5be4d8094f 100644
--- a/src/modules/[chain]/account/index.vue
+++ b/src/modules/[chain]/account/index.vue
@@ -55,6 +55,8 @@ function showPubkey(v: any) {
 <template>
     <div class=" overflow-x-auto">
         <table class="table table-compact">
+            <caption class="hidden">List Table</caption>
+            <th class="hidden"></th>
             <thead>
                 <tr>
                     <td>{{ $t('account.type') }}</td>
diff --git a/src/modules/[chain]/block/[height].vue b/src/modules/[chain]/block/[height].vue
index 34e55542c4..e1fd8b0c57 100644
--- a/src/modules/[chain]/block/[height].vue
+++ b/src/modules/[chain]/block/[height].vue
@@ -70,6 +70,8 @@ onBeforeRouteUpdate(async (to, from, next) => {
         </div>
         <div class="pt-10 flex justify-center">
           <table class="table w-max rounded-lg bg-base-100">
+            <caption class="hidden">List Table</caption>
+            <th class="hidden"></th>
             <tbody>
               <tr class="hover cursor-pointer" @click="edit = !edit">
                 <td>{{ $t('block.countdown_for_block') }}:</td>
diff --git a/src/modules/[chain]/block/index.vue b/src/modules/[chain]/block/index.vue
index 11752e0727..53ecaf972e 100644
--- a/src/modules/[chain]/block/index.vue
+++ b/src/modules/[chain]/block/index.vue
@@ -51,6 +51,7 @@ const list = computed(() => {
 
         <div v-show="tab === 'transactions'" class="bg-base-100 rounded overflow-x-auto">
             <table class="table w-full table-compact">
+                <caption class="hidden">Transactions</caption>
                 <thead class="bg-base-200">
                     <tr>
                         <th style="position: relative; z-index: 2;">{{ $t('account.height') }}</th>
diff --git a/src/modules/[chain]/cosmwasm/[code_id]/contracts.vue b/src/modules/[chain]/cosmwasm/[code_id]/contracts.vue
index 81ad852928..6ad0f77227 100644
--- a/src/modules/[chain]/cosmwasm/[code_id]/contracts.vue
+++ b/src/modules/[chain]/cosmwasm/[code_id]/contracts.vue
@@ -56,6 +56,7 @@ function showInfo(address: string) {
       </h2>
       <div class="overflow-x-auto">
         <table class="table table-compact w-full mt-4">
+          <caption class="hidden">Contracts</caption>
           <thead>
             <tr>
               <th style="position: relative; z-index: 2">{{ $t('cosmwasm.contract_list') }}</th>
diff --git a/src/modules/[chain]/cosmwasm/[code_id]/transactions.vue b/src/modules/[chain]/cosmwasm/[code_id]/transactions.vue
index 664692e183..37fea219b9 100644
--- a/src/modules/[chain]/cosmwasm/[code_id]/transactions.vue
+++ b/src/modules/[chain]/cosmwasm/[code_id]/transactions.vue
@@ -163,6 +163,8 @@ const result = ref('');
         <div class="bg-base-100 px-4 pt-3 pb-4 rounded mb-4 shadow">
             <h2 class="card-title truncate w-full mt-4">Transactions</h2>
             <table class="table">
+                <caption class="hidden">Transactions</caption>
+                <th class="hidden"></th>
                 <thead>
                     <tr>
                         <td> {{ $t('ibc.height') }}</td>
@@ -223,6 +225,8 @@ const result = ref('');
                         </div>
                         <div class="overflow-auto">
                             <table class="table table-compact w-full text-sm">
+                                <caption class="hidden">contracts states</caption>
+                                <th class="hidden"></th>
                                 <tr v-for="(v, index) in state.models" :key="index" class="hover">
                                     <td class="" :data-tip="format.hexToString(v.key)">
                                         <span class="font-bold">{{ format.hexToString(v.key) }}</span>
diff --git a/src/modules/[chain]/cosmwasm/index.vue b/src/modules/[chain]/cosmwasm/index.vue
index 8644408bca..ffedcb1e03 100644
--- a/src/modules/[chain]/cosmwasm/index.vue
+++ b/src/modules/[chain]/cosmwasm/index.vue
@@ -38,6 +38,7 @@ function myContracts() {
         </div>
         <div class="overflow-x-auto">
             <table class="table table-compact w-full mt-4 text-sm">
+                <caption class="hidden">contracts</caption>
                 <thead>
                     <tr>
                         <th>{{ $t('cosmwasm.code_id') }}</th>
diff --git a/src/modules/[chain]/gov/[proposal_id].vue b/src/modules/[chain]/gov/[proposal_id].vue
index 1eaf5cd7c7..91da165596 100644
--- a/src/modules/[chain]/gov/[proposal_id].vue
+++ b/src/modules/[chain]/gov/[proposal_id].vue
@@ -340,6 +340,8 @@ function pageload(p: number) {
       <h2 class="card-title">{{ $t('gov.votes') }}</h2>
       <div class="overflow-x-auto">
         <table class="table w-full table-zebra">
+          <caption class="hidden">Proposals</caption>
+          <th class="hidden"></th>
           <tbody>
             <tr v-for="(item, index) of votes" :key="index">
               <td class="py-2 text-sm">{{ showValidatorName(item.voter) }}</td>
diff --git a/src/modules/[chain]/ibc/connection/[connection_id].vue b/src/modules/[chain]/ibc/connection/[connection_id].vue
index ce6f484db7..3b7d677c76 100644
--- a/src/modules/[chain]/ibc/connection/[connection_id].vue
+++ b/src/modules/[chain]/ibc/connection/[connection_id].vue
@@ -52,12 +52,7 @@ function loadChannel(channel: string, port: string) {
 }
 
 function pageload(pageNum: number) {
-  if (direction.value === 'In') {
-    fetchSendingTxs(channel_id.value, port_id.value, pageNum -1)
-  } else {
-    fetchSendingTxs(channel_id.value, port_id.value, pageNum -1)
-  }
-
+  fetchSendingTxs(channel_id.value, port_id.value, pageNum -1)
 }
 
 function fetchSendingTxs(channel: string, port: string, pageNum = 0) {
@@ -133,6 +128,8 @@ function color(v: string) {
         clientState.client_state?.['@type'] }}</span></h2>
       <div class="overflow-x-auto grid grid-cols-1 md:grid-cols-2 gap-4">
         <table class="table table-sm capitalize">
+          <caption class="hidden">Connections</caption>
+          <th class="hidden"></th>
           <thead class="bg-base-200">
             <tr>
               <td colspan="3">{{ $t('ibc.trust_parameters') }}</td>
@@ -170,6 +167,8 @@ function color(v: string) {
           </tbody>
         </table>
         <table class="table table-sm text-sm w-full capitalize">
+          <caption class="hidden">Connections</caption>
+          <th class="hidden"></th>
           <thead class="bg-base-200">
             <tr>
               <td colspan="2">{{ $t('ibc.upgrade_parameters') }}</td>
@@ -201,6 +200,7 @@ function color(v: string) {
       <h2 class="card-title">{{ $t('ibc.channels') }}</h2>
       <div class="overflow-auto">
         <table class="table w-full mt-4">
+          <caption class="hidden">Connections</caption>
           <thead>
             <tr>
               <th>{{ $t('ibc.txs') }}</th>
@@ -277,6 +277,8 @@ function color(v: string) {
     <div v-if="channel_id">
       <h3 class=" card-title capitalize">Transactions ({{ channel_id }} {{ port_id }} {{ direction }}) </h3>
       <table class="table">
+        <caption class="hidden">Transactions</caption>
+        <th class="hidden"></th>
         <thead>
           <tr>
             <td> {{ $t('ibc.height') }}</td>
diff --git a/src/modules/[chain]/staking/[validator].vue b/src/modules/[chain]/staking/[validator].vue
index 78881ab577..3b75e47773 100644
--- a/src/modules/[chain]/staking/[validator].vue
+++ b/src/modules/[chain]/staking/[validator].vue
@@ -187,6 +187,7 @@ function pageload(p: number) {
                   v-if="avatars[identity] !== 'undefined'"
                   v-lazy="logo(identity)"
                   class="object-contain"
+                  alt="avatar"
                 />
                 <Icon
                   v-else
@@ -492,6 +493,7 @@ function pageload(p: number) {
       </div>
       <div class="rounded overflow-auto">
         <table class="table validatore-table w-full">
+          <caption class="hidden">Validators</caption>
           <thead>
             <th class="text-left pl-4" style="position: relative; z-index: 2">
               {{ $t('account.delegator') }}
@@ -518,6 +520,7 @@ function pageload(p: number) {
       <div class="text-lg mb-4 font-semibold">{{ $t('account.transactions') }}</div>
       <div class="rounded overflow-auto">
         <table class="table validatore-table w-full">
+          <caption class="hidden">Validators</caption>
           <thead>
             <th class="text-left pl-4" style="position: relative; z-index: 2">
               {{ $t('account.height') }}
diff --git a/src/modules/[chain]/staking/index.vue b/src/modules/[chain]/staking/index.vue
index 4632486e19..a1f4f78557 100644
--- a/src/modules/[chain]/staking/index.vue
+++ b/src/modules/[chain]/staking/index.vue
@@ -268,6 +268,7 @@ loadAvatars();
         <div class="bg-base-100 px-4 pt-3 pb-4 rounded shadow">
             <div class="overflow-x-auto">
                 <table class="table staking-table w-full">
+                    <caption class="hidden">Validators</caption>
                     <thead>
                         <tr>
                             <th
@@ -320,6 +321,7 @@ loadAvatars();
                                                 v-if="logo"
                                                 :src="logo"
                                                 class="object-contain"
+                                                alt="logo"
                                             />
                                             <Icon
                                                 v-else