Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track number metadata not included #743

Open
Batwam opened this issue Feb 24, 2024 · 29 comments
Open

Track number metadata not included #743

Batwam opened this issue Feb 24, 2024 · 29 comments
Labels
bug Something isn't working

Comments

@Batwam
Copy link

Batwam commented Feb 24, 2024

Hello,

I just downloaded a playlist including the track numbers. This works for the file name but I noticed that the track number is not included in the metadata. I initially thought to suggest doing it but I can see from #435 that this has been implemented. Is this meant to work? if so, it didn't work for me.

Ubuntu 23.10
Parabolic v2023.10.2 (flatpak)

@Batwam
Copy link
Author

Batwam commented Feb 26, 2024

ok, after our discussion on #742, I have noted that the track numbers are now showing when I download songs. I was going to mark this as closed but couldn't quite let it go as I couldn't understand why this changed. So, I went back, turn that back off and the track numbers disappeared again. bingo!

exiftool data with Metadata scrubbing on (left) and off (right):
Screenshot from 2024-02-25 22-05-43

as you can see, the right hand side has the video link but it's also missing the track number (the rest of the data cropped at the top is identical between both files). Even the order between Artist/Year/Album is different between both sides so,it looks like this option does more than just removing the comment, it also adds the track number?

@nlogozzo nlogozzo added the bug Something isn't working label May 15, 2024
@nlogozzo
Copy link
Member

nlogozzo commented Sep 4, 2024

@Batwam Could you test this release and let me know what happens: https://github.com/NickvisionApps/Parabolic/releases/tag/2024.9.0-beta1

@nlogozzo nlogozzo added the waiting-for-author Waiting for a response from the author of the issue label Sep 4, 2024
@Batwam
Copy link
Author

Batwam commented Sep 8, 2024

just tried installing the snap version. it crashes with the following error
Content snap command-chain for /snap/tube-converter/576/gpu-2404/bin/gpu-2404-provider-wrapper not found: ensure slot is connected

@Batwam
Copy link
Author

Batwam commented Sep 8, 2024

More of a beta version issue but while the flatpak starts, I get the following error when inputing the url (I have selected my browser in the preferences even though this isn't something I had to do in the previous versions):
image

it works fine when using yt-dlp directly though.

@nlogozzo
Copy link
Member

nlogozzo commented Sep 8, 2024

just tried installing the snap version. it crashes with the following error
Content snap command-chain for /snap/tube-converter/576/gpu-2404/bin/gpu-2404-provider-wrapper not found: ensure slot is connected

@soumyaDghosh

@nlogozzo
Copy link
Member

nlogozzo commented Sep 8, 2024

More of t a beta version issue but I can't test, flatpak starts but I get the following error when inputing the url (I have selected my browser in the preferences even though this isn't something I had to do in the previous versions):
image

it works fine when using yt-dlp directly though.

What's the link and what's the browser?

@soumyaDghosh
Copy link
Member

just tried installing the snap version. it crashes with the following error
Content snap command-chain for /snap/tube-converter/576/gpu-2404/bin/gpu-2404-provider-wrapper not found: ensure slot is connected

@soumyaDghosh

I have no idea, why your snaps are facing this! I guess it's time to get serious about this.

@Batwam
Copy link
Author

Batwam commented Sep 8, 2024

If that helps, I had a look at the content of the folder and there is no gpu-2404 folder in it. There is also no file called provider-wrapper anywhere within /snap/tube-converter.

@Batwam
Copy link
Author

Batwam commented Sep 8, 2024

What's the link and what's the browser?

it's the same with any song. For example this Creative Common song: https://youtu.be/5yIbZVOv438?si=RDyV4tLhapccgSGS
browser is firefox. Same thing is I specify chrome (which is also installed). I haven't specified a link to a Cookies files as I never had to before and don't need to do it with yt-dlp. not sure if this is required or not (and the error only says "selected browser"...

@soumyaDghosh
Copy link
Member

If that helps, I had a look at the content of the folder and there is no gpu-2404 folder in it. There is also no file called provider-wrapper anywhere within /snap/tube-converter.

I know why it's happening, and how to fix it. I'm just furious why is it happening. It should not be the case!

Anyways, thanks a lot for taking your time to look into it. To fix it run

sudo snap connect tube-converter:gpu-2404 mesa-2404

@Batwam
Copy link
Author

Batwam commented Sep 8, 2024

Thanks for the help, I ran the command above, now I'm getting this:
Content snap command-chain for /snap/tube-converter/576/gnome-platform/command-chain/desktop-launch not found: ensure slot is connected

@soumyaDghosh
Copy link
Member

soumyaDghosh commented Sep 8, 2024

sudo snap connect tube-converter:gnome-46-2404 gnome-46-2404
sudo snap connect tube-converter:ffmpeg-2404 ffmpeg-2404

Can you kindly try this? @Batwam

@Batwam
Copy link
Author

Batwam commented Sep 9, 2024

yeah, it's starting now, it does show the following errors in the terminal though:

libpxbackend-1.0.so: cannot open shared object file: No such file or directory
Failed to load module: /home/anthony/snap/tube-converter/common/.cache/gio-modules/libgiolibproxy.so

as well as the following Warnings:

(org.nickvision.tubeconverter.gnome:919141): Adwaita-WARNING **: 08:01:03.832: AdwNavigationPage 0x60fd514ef250 is missing a title. To hide a header bar title, consider using AdwHeaderBar:show-title instead.

(org.nickvision.tubeconverter.gnome:919141): Adwaita-WARNING **: 08:01:03.833: AdwNavigationPage 0x60fd5153c110 is missing a title. To hide a header bar title, consider using AdwHeaderBar:show-title instead.

interestingly though, downloading the link above does work with the snap version (didn't even have to specify a browser, in fact, the option isn't even there... Perhaps a permission/access issue with the flatpak version then?

@nlogozzo
Copy link
Member

nlogozzo commented Sep 9, 2024

yeah, it's starting now, it does show the following errors in the terminal though:

libpxbackend-1.0.so: cannot open shared object file: No such file or directory
Failed to load module: /home/anthony/snap/tube-converter/common/.cache/gio-modules/libgiolibproxy.so

as well as the following Warnings:

(org.nickvision.tubeconverter.gnome:919141): Adwaita-WARNING **: 08:01:03.832: AdwNavigationPage 0x60fd514ef250 is missing a title. To hide a header bar title, consider using AdwHeaderBar:show-title instead.

(org.nickvision.tubeconverter.gnome:919141): Adwaita-WARNING **: 08:01:03.833: AdwNavigationPage 0x60fd5153c110 is missing a title. To hide a header bar title, consider using AdwHeaderBar:show-title instead.

interestingly though, downloading the link above does work with the snap version (didn't even have to specify a browser, in fact, the option isn't even there... Perhaps a permission/access issue with the flatpak version then?

The flatpak version also is not supposed to show this option...and I can confirm that it doesn't.

Is there something weird with ur flatpak installation?

@Batwam
Copy link
Author

Batwam commented Sep 9, 2024

For clarity, the errors in the message right above come from the snap installation. The snap version now launches and successfully downloads.

The flatpak version launches but fails to download as per the errors above about the browser. Flatpak instal is standard as far as I can tell.

@nlogozzo
Copy link
Member

nlogozzo commented Sep 9, 2024

image

It works for me no problem on Flatpak.

@nlogozzo nlogozzo removed the waiting-for-author Waiting for a response from the author of the issue label Sep 9, 2024
@nlogozzo
Copy link
Member

nlogozzo commented Sep 9, 2024

It does seem tho as the flatpak version cannot correctly detect that it is running under flatpak. But as long as you keep Cookies from Browser to None and don't upload a cookies file, it should work just fine.

I'm going to fix the detection tho and maybe it will fix your flatpak too.

@Batwam
Copy link
Author

Batwam commented Sep 9, 2024

Ok, could it be because firefox is running as a snap and the files aren't where parabolic expects to find them?

The snap version of parabolic is working fine so I'll give that a go for now.

@nlogozzo
Copy link
Member

nlogozzo commented Sep 9, 2024

Ok, could it be because firefox is running as a snap and the files aren't where parabolic expects to find them?

The problem is Flatpak sandboxes the filesystem so yt-dlp can't find anything where it expects it to be.

So on flatpak and snap we disable the choice of cookies for the browser and only allow manually uploading a cookies file.

@Batwam
Copy link
Author

Batwam commented Sep 9, 2024

ok, I'm definitely seeing the option for choice of cookies for the browser with the flatpak version (not the snap). Are you saying that it shouldn't be there?
image

@nlogozzo
Copy link
Member

nlogozzo commented Sep 9, 2024

Are you saying that it shouldn't be there?

Correct. You should leave that as None for now. It will disappear in the next beta.

@nlogozzo
Copy link
Member

nlogozzo commented Sep 9, 2024

@Batwam Either way...is the track number included in the metadata on the snap version? 😅

@Batwam
Copy link
Author

Batwam commented Sep 10, 2024

yeah, I haven't forgotten about the initial issue, just struggling to even get to a point where I can download files and check 😅

I just tried with a new playlist and get the following (using the snap):
ERROR: Postporcessing: ffprobe and ffmpeg not found. Please install or provide the path using --ffmpeg-location
these programes are in the usual \usr\bin location...

@soumyaDghosh
Copy link
Member

sudo snap connect tube-converter:gnome-46-2404 gnome-46-2404
sudo snap connect tube-converter:ffmpeg-2404 ffmpeg-2404

Can you kindly try this? @Batwam

@Batwam You didn't connect both of these. Run the second one properly.

@Batwam
Copy link
Author

Batwam commented Sep 10, 2024

I did, several times but I'm still having the same issue

@nlogozzo
Copy link
Member

I did, several times but I'm still having the same issue

I will releasing a new beta later tonight. Hopefully that flatpak will work for you.

@Batwam
Copy link
Author

Batwam commented Sep 11, 2024

just tried the beta2 version in flatpak, still the same issue. I even tried to generate a cookies text file (using this code) and add it to the preferences an still face the same issue. Frankly, having to extract the cookies from the sqlite database to a text file for this seems overly convoluted. I'd rather use the snap if that allows to avoid this extra manual step.

@nlogozzo
Copy link
Member

Using cookies is NOT REQUIRED for Parabolic to work. A cookies file is only required when trying to download age-restricted videos, according to yt-dlp.

In Preferences you can leave Cookies from Browser as None and clear the Cookies File and leave it blank. And your downloads should work no problem.

FYI, there are extensions available for all major browsers that will extract a cookies txt file for you.

@Batwam
Copy link
Author

Batwam commented Sep 11, 2024

ok, that's good to know. I used the python code mentioned above and that worked too (I think).
I'm not planning to download age-restricted content so I set the browser to None and it's now working. By the way, the error is a bit vague as it mentioned 3 possible reasons (url, authentication, cookies). Is there a way to narrow it down based on the error code so the user knows which of the 3 it might be?

Back to the original issue, I have run a test with a playlist and found that the track number isn't embedded. Is there a specific option I need to select for this (I have the option to include the Number Title on, although I noticed that it is off by default and I have to reactivate it every time).

Also, the option to Remove Source Data doesn't appear to be doing anything as the data is still there in the Exif field "User Defined Text". I compared the output from exiftool with the option on/off and they are identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants