Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary template arguments from the whole code. #131

Open
martun opened this issue Jan 11, 2024 · 0 comments
Open

Remove unnecessary template arguments from the whole code. #131

martun opened this issue Jan 11, 2024 · 0 comments

Comments

@martun
Copy link
Contributor

martun commented Jan 11, 2024

Currently all of suite uses classes, which have lots of template arguments. For example this class is used as a template argument in many places:

https://github.com/NilFoundation/crypto3-zk/blob/ebac50dbc72109b55d0c94d934ef8ff15fe747de/include/nil/crypto3/zk/snark/systems/plonk/placeholder/params.hpp#L61

Most of these values must be dynamically assigned, so we don't need to re-compile after any arithmetization parameter change.
This also slows down compilation of tests a LOT, also compilation requires more and more RAM on our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant