Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dot placement issue. #15

Closed
fnldstntn opened this issue Sep 23, 2020 · 4 comments
Closed

Dot placement issue. #15

fnldstntn opened this issue Sep 23, 2020 · 4 comments
Assignees
@thearchetypee
Labels
bug Something isn't working hacktoberfest Open for contributions as a part of Hacktoberfest 2020

Comments

@fnldstntn
Copy link

fnldstntn commented Sep 23, 2020 •
edited
Loading

First great app.
Because my phones screen corners are rounded the dot is going under the rounded corner and isn't visible, i can see only edge of the dot. Can you add an option to place the dot on the top center. On the screen shot the problem isn't visible. I can get around this problem by making the dot bigger but i didn't like that way.
Thanks.
@NitishGadangi
Copy link
Owner

Thanks, adding an option to add padding from the Edge might fix this issue.
Noted for the next release.

Thanks for reporting the issue.

@NitishGadangi NitishGadangi added bug Something isn't working hacktoberfest Open for contributions as a part of Hacktoberfest 2020 labels Sep 23, 2020
@thearchetypee
Copy link

Hi Nitish! I would like to work on this. Can you assign this to me?

@NitishGadangi
Copy link
Owner

@aayush287 Most Welcome 😀

thearchetypee added a commit to thearchetypee/Privacy-Indicator-App that referenced this issue Sep 27, 2020
@thearchetypee
type: Dot placement fixed from issue NitishGadangi#15
4b4c0ef
@thearchetypee thearchetypee mentioned this issue Oct 1, 2020
Closed
@NitishGadangi
Copy link
Owner

Fixed in #21
Will be Improved in #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearchetypee thearchetypee

Labels
bug Something isn't working hacktoberfest Open for contributions as a part of Hacktoberfest 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dot placement center thearchetypee/Privacy-Indicator-App
3 participants
@fnldstntn @NitishGadangi @thearchetypee