-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eval errors make jobset and eval pages very expensive to serve and browse #1362
Comments
FWIW when I checked the SQL query associated with loading that page returned 225MB of data. I'm not sure how it ends up getting condensed to 25MB though, but if I did actually get the 225MB measurement right then it's an even more critical performance issue.
Or just make it a link? I don't think we lose much by not having the errors be inline in the page, tbf. If that simplifies the implementation... |
Given that browsers do the heavy lifting for us, I think iframes can be the drop-in replacement. |
Why even go for an iframe? Using a discrete page is always the better choice. That is, rather than trying to be "smart" with lazy loading, and/or js, and/or DOM-based tabs. Though since the expectations vary wildly with tab-based navigation, it would be best if it was a discrete link/action in the blurb above the search input. |
No strong opinion. My impression was that it would be the simplest drop-in replacement. |
Closes NixOS#1362 (cherry picked from commit b45f473)
I've done another pass in 6189ba9 this time actually removing DB fetches when possible. h.n.o loads considerably faster. There are probably some other places where |
Describe the bug
Eval errors make up a large part of what hydra has to ship to users when browsing jobsets or evals.
nixpkgs/staging-next
is 26 MB in sizeTo Reproduce
Steps to reproduce the behavior:
Expected behavior
These pages should be quick to load and not create load on the hydra webserver.
Proposal
Create a separate route for requesting eval errors and embed that endpoint via an iframe that gets lazily loaded, when it comes into the viewport.
The eval errors should also be shipped in plaintext and not be passed through the template engine.
Hydra Server:
hydra.nixos.org
The text was updated successfully, but these errors were encountered: