Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.torch: package NNPACK separately #288140

Open
SomeoneSerge opened this issue Feb 11, 2024 · 0 comments
Open

python3Packages.torch: package NNPACK separately #288140

SomeoneSerge opened this issue Feb 11, 2024 · 0 comments

Comments

@SomeoneSerge
Copy link
Contributor

SomeoneSerge commented Feb 11, 2024

Issue description

Torch needs to be rid of fetchSubmodules = true (they prevent dependency injection; #239291, #277789, #276585), but in particular in #285249 we encountered the need to patch and configure NNPACK (unconditionally downloads dependencies from the internet without any error handling, fails configuration phase by running python with an invalid PYTHONPATH). Doing so inside the torch derivation would be cumbersome and doesn't scale (many more git-submodule time bombs). We should handle NNPACK once, without adding complexity to the torch expression. We should also ensure we can pass cmakeFlags to torch (currently obstructed by the setup.py wrapper)

References

#239211

Technical details

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants