Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Bug] Unbalanced base predictions fail to reshape forreconciler_args #213

Open
kdgutier opened this issue Jun 20, 2023 · 1 comment
Labels

Comments

@kdgutier
Copy link
Collaborator

Currently, HierarchicalForecast methods require the base predictions to be "balanced", i.e., all the predictions must be available for all the series and forecast creation dates.

If the base forecast inputs are not balanced, the following reshapes fail:

y_hat = Y_hat_df[model_name].values.reshape(len(S_df), -1).astype(np.float32)
y_insample = Y_df['y'].values.reshape(len(S_df), -1).astype(np.float32)

The is_balanced parameter is already available, but a Raise.Exception to check the input characteristics can help.

@elephaint elephaint added the bug label Nov 14, 2024
@elephaint
Copy link
Contributor

I've seen this issue too - this also ties in to #290 - it seems the checks / required data should be method-specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants