Non-equatable requests in 2.0

[eimantas]

Hi!

Are there plans to readd the hooks for non-equatable values returned from state requests? In 1.X it was possible to pass own == function that would always return false for such cases. In 2.0 there doesn't seem to be one left.

Best,

[eliekarouz]

@eimantas ,

Speaking of the devil, I've recently opened a pull request at RxFeedback.kt and pointed the same issue there.

@kzaher ,

• Any reasons why this overload was removed?
• If we want to support it, do we need it to support it for the most general form too?
  In Kotlin, I managed to do it for the simple react without having to introduce it to the most general form. Not sure if this is what you want...

Thanks,
Elie

[kzaher]

Are there plans to readd the hooks for non-equatable values returned from state requests? In 1.X it was possible to pass own == function that would always return false for such cases. In 2.0 there doesn't seem to be one left.

This was a crutch until compiler was ready to make auto Equatable convenient. It was kind of a practical hack.

Don't think we need this anymore.

[eimantas]

Don't think we need this anymore.

Do you mean there is no need to support non-equatable requests?

[kzaher]

This was a crutch until compiler was ready to make auto Equatable convenient. It was kind of a practical hack.

[eimantas]

What about non-nominal types returned from states?

[DanielAsher]

I've also run into this problem. I've got a large project with hundreds of state structs that don't have an Equatable operator. I started to implement these, but after a couple of hours gave up as I hadn't given my developers instructions to do this prior and would require too many guesses before a release. We also have stencils that generate Equatables, so having to revisit this system was very unpalatable.

This is currently stopping me kicking the tires on RxSwift 5.0.1 as carthage update --platform ios --new-resolver --verbose simply hangs.

Carthage/Carthage#2615