Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create platform specific builds of the vsix #534

Open
kanej opened this issue Dec 5, 2023 · 0 comments · May be fixed by #612
Open

Create platform specific builds of the vsix #534

kanej opened this issue Dec 5, 2023 · 0 comments · May be fixed by #612
Labels
status:ready This issue is ready to be worked on

Comments

@kanej
Copy link
Member

kanej commented Dec 5, 2023

We currently bundle every version of the @nomicfoundation/solidity-analyzer for every platform, so that one vsix can be used across all platforms.

We should switch to platform specific vsix files. To reduce the size of installs. This will involve reworking the release and build processes.

For details on platform specific vsix files and publication see:
https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions
@kanej kanej mentioned this issue Dec 5, 2023
Merged
@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Jul 29, 2024
@kanej kanej moved this to Todo in hardhat-vscode Aug 1, 2024
gordon-to added a commit to gordon-to/hardhat-vscode that referenced this issue Nov 14, 2024
@gordon-to
feat(NomicFoundation#534): platform specific builds of vsix
3fa370e 
based on https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml
gordon-to added a commit to gordon-to/hardhat-vscode that referenced this issue Nov 14, 2024
@gordon-to
feat(NomicFoundation#534): platform specific builds of vsix
0a1daec 
based on https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml
gordon-to added a commit to gordon-to/hardhat-vscode that referenced this issue Nov 14, 2024
@gordon-to
feat(NomicFoundation#534): platform specific builds of vsix
09024ca 
based on https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml
gordon-to added a commit to gordon-to/hardhat-vscode that referenced this issue Nov 14, 2024
@gordon-to
feat(NomicFoundation#534): platform specific builds of vsix
011f0a4 
based on https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml
gordon-to added a commit to gordon-to/hardhat-vscode that referenced this issue Nov 14, 2024
@gordon-to
feat(NomicFoundation#534): platform specific builds of vsix
b7a4ca0 
based on https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml
gordon-to added a commit to gordon-to/hardhat-vscode that referenced this issue Nov 14, 2024
@gordon-to
feat(NomicFoundation#534): platform specific builds of vsix
0120264 
based on https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml
@gordon-to gordon-to linked a pull request Nov 14, 2024 that will close this issue
Open
gordon-to added a commit to gordon-to/hardhat-vscode that referenced this issue Nov 14, 2024
@gordon-to
feat(NomicFoundation#534): platform specific builds of vsix
c4cd326 
based on https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
hardhat-vscode
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#534): platform specific builds of vsix gordon-to/hardhat-vscode
1 participant
@kanej