From 16cfca050e44ff42287242f055f9281b8a5c8b75 Mon Sep 17 00:00:00 2001 From: Jack Rubacha Date: Fri, 17 Jan 2025 16:38:00 -0500 Subject: [PATCH 1/7] update ci --- .github/workflows/build-check.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-check.yml b/.github/workflows/build-check.yml index 5ee76bb..bc27b33 100644 --- a/.github/workflows/build-check.yml +++ b/.github/workflows/build-check.yml @@ -7,14 +7,9 @@ jobs: image: ghcr.io/northeastern-electric-racing/embedded-base:main timeout-minutes: 10 steps: - - name: Checkout code - uses: actions/checkout@v4 - with: - submodules: recursive - - name: Execute Make run: | - if ! make; then + if ! docker compose run --rm ner-gcc-arm make -j `nproc`; then echo "The application has failed to build." exit 1 # This will cause the workflow to fail - fi \ No newline at end of file + fi From 0f1f49fb4d7bf062c0a0f9ac909a50dd8540f4cf Mon Sep 17 00:00:00 2001 From: Jack Rubacha Date: Fri, 17 Jan 2025 17:12:02 -0500 Subject: [PATCH 2/7] fix --- .github/workflows/build-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-check.yml b/.github/workflows/build-check.yml index bc27b33..2e74be4 100644 --- a/.github/workflows/build-check.yml +++ b/.github/workflows/build-check.yml @@ -7,6 +7,7 @@ jobs: image: ghcr.io/northeastern-electric-racing/embedded-base:main timeout-minutes: 10 steps: + - uses: actions/checkout@v4 - name: Execute Make run: | if ! docker compose run --rm ner-gcc-arm make -j `nproc`; then From aa211ae5e50735764720304e472493c5dda33e2c Mon Sep 17 00:00:00 2001 From: Jack Rubacha Date: Fri, 17 Jan 2025 17:16:23 -0500 Subject: [PATCH 3/7] try dash --- .github/workflows/build-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-check.yml b/.github/workflows/build-check.yml index 2e74be4..9091514 100644 --- a/.github/workflows/build-check.yml +++ b/.github/workflows/build-check.yml @@ -10,7 +10,7 @@ jobs: - uses: actions/checkout@v4 - name: Execute Make run: | - if ! docker compose run --rm ner-gcc-arm make -j `nproc`; then + if ! docker-compose run --rm ner-gcc-arm make -j `nproc`; then echo "The application has failed to build." exit 1 # This will cause the workflow to fail fi From 58c9590dc7aa43d4a4366190d7c440c7f2beb90f Mon Sep 17 00:00:00 2001 From: Jack Rubacha Date: Fri, 17 Jan 2025 17:18:29 -0500 Subject: [PATCH 4/7] send --- .github/workflows/build-check.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/build-check.yml b/.github/workflows/build-check.yml index 9091514..7e4c5ec 100644 --- a/.github/workflows/build-check.yml +++ b/.github/workflows/build-check.yml @@ -9,8 +9,4 @@ jobs: steps: - uses: actions/checkout@v4 - name: Execute Make - run: | - if ! docker-compose run --rm ner-gcc-arm make -j `nproc`; then - echo "The application has failed to build." - exit 1 # This will cause the workflow to fail - fi + run: docker compose run --rm ner-gcc-arm make -j `nproc` From 3f729b45a3f33af16520c503739c12940c9a1ac8 Mon Sep 17 00:00:00 2001 From: Jack Rubacha Date: Fri, 17 Jan 2025 17:19:29 -0500 Subject: [PATCH 5/7] simplify --- .github/workflows/build-check.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-check.yml b/.github/workflows/build-check.yml index 7e4c5ec..2e10c7f 100644 --- a/.github/workflows/build-check.yml +++ b/.github/workflows/build-check.yml @@ -3,10 +3,12 @@ on: [push] jobs: run-build: runs-on: ubuntu-latest - container: - image: ghcr.io/northeastern-electric-racing/embedded-base:main timeout-minutes: 10 steps: - uses: actions/checkout@v4 - name: Execute Make - run: docker compose run --rm ner-gcc-arm make -j `nproc` + run: | + if ! docker compose run --rm ner-gcc-arm make -j `nproc`; then + echo "The application has failed to build." + exit 1 # This will cause the workflow to fail + fi From 7c007db08c21503e402899edf0b4df117a691a79 Mon Sep 17 00:00:00 2001 From: Jack Rubacha Date: Fri, 17 Jan 2025 17:20:54 -0500 Subject: [PATCH 6/7] fix checkout --- .github/workflows/build-check.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-check.yml b/.github/workflows/build-check.yml index 2e10c7f..b3f0460 100644 --- a/.github/workflows/build-check.yml +++ b/.github/workflows/build-check.yml @@ -5,7 +5,10 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 10 steps: - - uses: actions/checkout@v4 + - name: Checkout code + uses: actions/checkout@v4 + with: + submodules: recursive - name: Execute Make run: | if ! docker compose run --rm ner-gcc-arm make -j `nproc`; then From 0d1f03dd6a9ff828691fca607242bfac213ebfa2 Mon Sep 17 00:00:00 2001 From: Jack Rubacha Date: Fri, 17 Jan 2025 17:29:06 -0500 Subject: [PATCH 7/7] final fixups --- .github/workflows/build-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-check.yml b/.github/workflows/build-check.yml index b3f0460..2390778 100644 --- a/.github/workflows/build-check.yml +++ b/.github/workflows/build-check.yml @@ -9,6 +9,7 @@ jobs: uses: actions/checkout@v4 with: submodules: recursive + fetch-depth: 0 - name: Execute Make run: | if ! docker compose run --rm ner-gcc-arm make -j `nproc`; then