Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoC eeprom, coulomb counting #75

Closed
wants to merge 11 commits into from
Closed

SoC eeprom, coulomb counting #75

wants to merge 11 commits into from

Conversation

Sabramz
Copy link
Contributor

@Sabramz Sabramz commented Jan 27, 2024

Changes

Added soc to eeprom. Added eeprom fault to faults table (just in case something goes boom). Edited calc_S_o_C to use coulomb counting.

Notes

My idea for calibration doesn't work. We will either use manual calibration like Nick said, or we find some other way to do it. Also, there is currently no way for the function to get access to a timer that can give it the delta time necessary to coulomb count.

To Do

Any remaining things that need to get done

  • Timer on coulomb counting
  • A working or more precise calibration system

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@Sabramz Sabramz self-assigned this Jan 27, 2024
@Sabramz Sabramz requested a review from dyldonahue January 27, 2024 15:38
@Sabramz Sabramz linked an issue Jan 27, 2024 that may be closed by this pull request
@dyldonahue
Copy link
Contributor

a few things:

  • fix submodule issues, first jsu ttry updating ur local submodule

  • i think, just because this is will be hard to test without just seeing the output, it would be cool to maintain the code for the linear extrapolation (current method of calculating SoC). Maybe implement this in parallel so that we can see the result of both, and we can move to this permanently once we are confident it works well

  • i dont know how this should work well enough so im gonna request some other peeps to keep an eye on this PR too

@Sabramz Sabramz changed the base branch from main to develop April 3, 2024 02:40
@Sabramz Sabramz closed this Jun 18, 2024
@Sabramz Sabramz deleted the 7-coulomb-counting branch June 18, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coulomb Counting
2 participants