Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send all Cell Data over CAN #9

Open
dyldonahue opened this issue Sep 3, 2023 · 7 comments · May be fixed by #138
Open

Send all Cell Data over CAN #9

dyldonahue opened this issue Sep 3, 2023 · 7 comments · May be fixed by #138
Assignees
Labels
enhancement New feature or request HIGH PRIORITY for work that is blocking or otherwise needs immediate attention

Comments

@dyldonahue
Copy link
Contributor

Another ticket that was investigated for Shepherd 1.0, but never completed. See the info here (PR), and here (ticket), Mainly, we need to address the issue explained by @mccauleyma in the comments of that ticket, but a lot of the work may already be done in that PR

@dyldonahue dyldonahue added enhancement New feature or request Not Available Blocked by other work, or being reconsidered. Do not Assign labels Sep 3, 2023
@dyldonahue dyldonahue removed the Not Available Blocked by other work, or being reconsidered. Do not Assign label Sep 14, 2023
@dyldonahue
Copy link
Contributor Author

I’m not going to close this yet, but i dont think this is a really necessary. Not worth the overhead of CAN spam, but open to different opinions

@mccauleyma
Copy link
Member

@dyldonahue, if time allows, I'd recommend still matching the Orions ability to do this. The way it was done there was this was an extra setting you could enable during firmware upload and is not recommend for normal day to day use. It's a diagnostic tool for debugging the battery pack. Definitely nice to have if we have time to spare.

@dyldonahue
Copy link
Contributor Author

That makes sense. If remote over IP works, we would be able to achieve this by just reading serial data remotely, but this shouldn't be hard to do so I will plan to get it done

@mccauleyma
Copy link
Member

If you'd prefer that method that works for me. As long as it can be recorded so we can export to MATLAB or whatever we need to analyze

@mccauleyma
Copy link
Member

I guess maybe the argument for CAN is being viewable with our telemetry viewing software. But not a big deal. Any situation that we're looking at cell by cell data we are probably looking at a big issue that we need to manually analyze anyways

@dyldonahue
Copy link
Contributor Author

Ok nah I was off base with what we wanted to do with this, if we wanna export it for longer term control can is best. There will be plenty of time to do this so it should be fine

@jr1221
Copy link
Contributor

jr1221 commented Aug 6, 2024

@Sabramz I can take care of this after #108 .

@jr1221 jr1221 self-assigned this Aug 6, 2024
@Sabramz Sabramz added the HIGH PRIORITY for work that is blocking or otherwise needs immediate attention label Sep 21, 2024
@jr1221 jr1221 removed their assignment Sep 24, 2024
@caiodasilva2005 caiodasilva2005 self-assigned this Nov 3, 2024
@caiodasilva2005 caiodasilva2005 self-assigned this Nov 27, 2024
@Sabramz Sabramz assigned Sabramz and unassigned caiodasilva2005 Jan 18, 2025
@Sabramz Sabramz linked a pull request Jan 18, 2025 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HIGH PRIORITY for work that is blocking or otherwise needs immediate attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants