Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] fancy logs #121

Open
Novakasa opened this issue Apr 30, 2023 · 3 comments
Open

[Feature] fancy logs #121

Novakasa opened this issue Apr 30, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Novakasa
Copy link
Owner

Is your feature request related to a problem? Please describe.
When people encounter issues with Brickrail, it will be really helpful to have some information of what was going on internally in brickrail. Currently, only the BLEserver stdout is accessible to the user.

Describe the solution you'd like
Add automatic log files. We already have the logger singleton but let's investigate other solutions as well.

@Novakasa Novakasa added the enhancement New feature or request label Apr 30, 2023
@Novakasa Novakasa added this to the 1.0 milestone Apr 30, 2023
@Novakasa Novakasa self-assigned this Apr 30, 2023
@Novakasa
Copy link
Owner Author

Novakasa commented May 1, 2023

It would be useful if log messages could be assigned to "topics" and I can then filter these topics to debug certain things. This doesn't seem to be a feature in any existing Godot logger, so might need to create a custom solution there.

@Novakasa Novakasa changed the title [Feature] add logs [Feature] fancy logs May 1, 2023
@Novakasa
Copy link
Owner Author

Novakasa commented May 2, 2023

We do have basic logs now, using automatic logging feature of godot and new logging plugin. Keeping this open because of the "topics" feature, making the Logger Singleton custom

@Novakasa Novakasa removed this from the 1.0 milestone May 4, 2023
@Novakasa
Copy link
Owner Author

also we could have a log-dispatcher class, where each object creates a new instance and stores the constants like which topic, which logging module in this instance and each logging call goes through that instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant