Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo test with minimal versions fails #6

Open
Nemo157 opened this issue Feb 23, 2019 · 2 comments
Open

Cargo test with minimal versions fails #6

Nemo157 opened this issue Feb 23, 2019 · 2 comments

Comments

@Nemo157
Copy link
Member

Nemo157 commented Feb 23, 2019

proptest depends on rand, which currently fails to build with minimal versions: rust-random/rand#741

Once that's resolved should try to change the minimal CI job from just building to actually running the tests.

@chrysn
Copy link
Contributor

chrysn commented Jun 14, 2023

Can't we just increment the MSRV? The issue is 4 years old, I doubt anyone is still on that stable version.

@Nemo157
Copy link
Member Author

Nemo157 commented Jun 14, 2023

This isn't about MSRV, that policy isn't actually stated but my standard policy is to only guarantee support of the latest stable at time of a release. It's about using cargo update -Z minimal-versions and running the tests with that, to check that the dependency declarations are correct (it doesn't guarantee that it'll work with all valid dependency combinations, but testing the minimum and maximum boundaries go a long way towards it).

There's a job doing cargo minimal-versions check already, and running cargo minimal-versions test locally it looks like it is actually working now (the version of rand being chosen must be high enough to work). I just need to figure out some nice way to have an optional job to run the test now (I share my github-actions configuration between multiple repos and some others don't work still).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants