Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][mig]-purchase_request_analytic #539

Merged
merged 16 commits into from
Jul 26, 2023
Merged

[15.0][mig]-purchase_request_analytic #539

merged 16 commits into from
Jul 26, 2023

Conversation

JuanyDForgeflow
Copy link

@JuanyDForgeflow JuanyDForgeflow commented Feb 13, 2023 •
edited
Loading

@ForgeFlow

Re-open #466

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-purchase_request_analytic branch from c863ce4 to c9ab090 Compare February 13, 2023 21:27
AaronHForgeFlow
AaronHForgeFlow reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can take the advantage a do a refactor in this module. Same as it was done with the purchase_analytic module here: #478

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-purchase_request_analytic branch from c9ab090 to 42a73a9 Compare February 13, 2023 23:26
@JuanyDForgeflow
Copy link
Author

@AaronHForgeFlow please check now

@AaronHForgeFlow
Copy link
Contributor

purchase_request_analytic

Hi @JuanyDForgeflow On the creation it does not fill the analytic account in the lines, it works after it is saved. Is it possible to fix that?

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-purchase_request_analytic branch 2 times, most recently from d1c3585 to 90404fc Compare February 14, 2023 23:49
@JuanyDForgeflow
Copy link
Author

@AaronHForgeFlow please review now

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-purchase_request_analytic branch from 90404fc to 02d418d Compare February 14, 2023 23:56
@AaronHForgeFlow
Copy link
Contributor

Hi @JuanyDForgeflow It seems that the analytic account field is now readonly in the lines, but they should be editable. Can you check?

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-mig-purchase_request_analytic branch from 02d418d to 19c3e86 Compare June 7, 2023 13:56
@AaronHForgeFlow
Copy link
Contributor

Hi @JuanyDForgeflow It seems that the analytic account field is now readonly in the lines, but they should be editable. Can you check?

still this problem, all the rest works good.

bjeficent and others added 16 commits July 25, 2023 14:12
@bjeficent @JasminSForgeFlow
[10.0][ADD] purchase_request_analytic: Add analytic account to Purcha…
f4ce3ff 
…se Request
@AaronHForgeFlow @JasminSForgeFlow
[FIX]do not restrict picking type for analytic.
c656261 
[IMP]add tests
@oca-travis @JasminSForgeFlow
[UPD] Update purchase_request_analytic.pot
6e11206
@OCA-git-bot @JasminSForgeFlow
[ADD] icon.png
9dea9e5
@MiquelRForgeFlow @JasminSForgeFlow
[MIG] purchase_request_analytic: Migration to 12.0
db33856
@oca-travis @JasminSForgeFlow
[UPD] Update purchase_request_analytic.pot
33453cf
@OCA-git-bot @JasminSForgeFlow
[UPD] README.rst
105a912
@ps-tubtim @JasminSForgeFlow
[IMP] purchase_request_analytic: black, isort
6a14742
@ps-tubtim @JasminSForgeFlow
[MIG] purchase_request_analytic: Migration to 13.0
f4037f1
@oca-travis @JasminSForgeFlow
[UPD] Update purchase_request_analytic.pot
f8f06ee
@JasminSForgeFlow
[IMP] purchase_request_analytic: black, isort, prettier
4146504
@JasminSForgeFlow
[MIG] purchase_request_analytic: Migration to 14.0
3a27d70
@JasminSForgeFlow
[UPD] Update purchase_request_analytic.pot
97f6509
@OCA-git-bot @JasminSForgeFlow
[UPD] README.rst
2ed1134
@JasminSForgeFlow
[IMP] purchase_request_analytic: black, isort, prettier
db12c28
@JasminSForgeFlow
[MIG] purchase_request_analytic: Migration to 15.0
0566d42
@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-purchase_request_analytic branch from 19c3e86 to 0566d42 Compare July 25, 2023 08:42
@JasminSForgeFlow
Copy link
Contributor

Hi @JuanyDForgeflow It seems that the analytic account field is now readonly in the lines, but they should be editable. Can you check?

still this problem, all the rest works good.

it is fixed, Thanks

AaronHForgeFlow
AaronHForgeFlow approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests LGTM 👍

LoisRForgeFlow
LoisRForgeFlow approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM 👍

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-539-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fe8abaf into OCA:15.0 Jul 26, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ecd0c8e. Thanks a lot for contributing to OCA. ❤️

@HviorForgeFlow HviorForgeFlow deleted the 15.0-mig-purchase_request_analytic branch July 26, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JuanyDForgeflow @AaronHForgeFlow @JasminSForgeFlow @OCA-git-bot @LoisRForgeFlow @bjeficent @oca-travis @MiquelRForgeFlow @ps-tubtim