[16.0] account_statement_import_sheet_file: keep order of rows in imported file

[cuongnmtm]

When importing bank statements using a sheet file that contains a column with timestamps in date format, the sequence of generated journal items may not match the sequence of lines in the imported file. This happens because the rows are currently being sorted by the timestamp column.

The code that sorts rows by timestamp:

bank-statement-import/account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

Line 68 in 9dca998

lines = list(sorted(lines, key=lambda line: line["timestamp"]))

Example:

STT No.	TNX Date/ CT/ Doc No	Effective date	Debit	Credit
1	02/01/2024 / 5254 - 96829	02/01/2024	6.000
2	02/01/2024 / 5136 - 09957	02/01/2024	2.000
3	02/01/2024 / 5136 - 10124	02/01/2024	2.000
4	02/01/2024 / 5136 - 10694	02/01/2024	7.000
5	02/01/2024 / 5136 - 11486	02/01/2024	15.000
6	03/01/2024 / 5009 - 07716	03/01/2024		15.000

generated these journal items

Describe the solution you'd like

A way to avoid sorting rows upon import to preserve their original order. Alternatively, allow for sorting by multiple columns.

[cuongnmtm]

I can submit a pull request to improve this, but I'm not sure which direction to take.

Maybe an option on the mapping to skip the sort.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.