[15.0][FIX] sale_commission: Salesmen can see invoice from SO #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - With a user with only sales permission and no invoicing one. - Go to an invoiced sales order. - Click on the smart-button "Invoice". You get a permission error on `account.invoice.line.agent` model. With this commit, we add read permission to salesmen over that object to avoid the problem. The other option would be to protect the view under the invoicing group, but it's interesting that salesmen can check its own invoices commissions. TT44083
chienandalu
approved these changes
Jun 27, 2023
victoralmau
approved these changes
Jun 27, 2023
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at f8d13a2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
You get a permission error on
account.invoice.line.agentmodel.With this commit, we add read permission to salesmen over that object to avoid the problem. The other option would be to protect the view under the invoicing group, but it's interesting that salesmen can check its own invoices commissions.
@Tecnativa TT44083