Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you think 0 is not a first class valid value to export? #490

Open
codingforfun opened this issue Sep 18, 2024 · 0 comments
Open

Why do you think 0 is not a first class valid value to export? #490

codingforfun opened this issue Sep 18, 2024 · 0 comments

Comments

@codingforfun
Copy link

https://github.com/OCA/connector/blame/3dd7b3a1fc58006e747534f54c940f073fa252d8/connector/components/mapper.py#L925

In direct mappings the ExportMapper replaces valid values of 0 with False in the mapping.
This is an invalid and unnecessary assumption about the specification of the meaning of 0 in the external interface we export to. I think this also doesn’t make much sense mathematically or otherwise and therefor is very unexpected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant