Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] fieldservice_activity #1183

Closed
wants to merge 48 commits into from
Closed

[17.0][MIG] fieldservice_activity #1183

wants to merge 48 commits into from

Conversation

Deriman-Alonso
Copy link
Member

Standart migration.

osi-scampbell and others added 30 commits April 23, 2024 14:10
@osi-scampbell @Deriman-Alonso
[ADD] fieldservice_activity
1f02809 
[IMP] Typo

[IMP] Form/Template Change

[IMP] Show/Hide Buttons

[IMP] PyLint

[IMP] Remove Commented Code

[IMP] Lint
@Deriman-Alonso
Added translation using Weblate (Spanish (Chile))
8055f21
@Deriman-Alonso
Translated using Weblate (Spanish (Chile))
28fd491 
Currently translated at 96.3% (26 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_CL/
@Deriman-Alonso
Translated using Weblate (Spanish (Chile))
d6eb9b1 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_CL/
@murtuzasaleh @Deriman-Alonso
[IMP] Improved code
4279dbc
@marcelsavegnago @Deriman-Alonso
Added translation using Weblate (Portuguese (Brazil))
5792199
@fcolus @Deriman-Alonso
Translated using Weblate (Portuguese (Brazil))
e3dc4c3 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/pt_BR/
@ibuioli @Deriman-Alonso
Added translation using Weblate (Spanish (Argentina))
646fd92
@ibuioli @Deriman-Alonso
Translated using Weblate (Spanish (Argentina))
4e14729 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/es_AR/
@dreispt @Deriman-Alonso
Added translation using Weblate (Portuguese (Portugal))
49863bb
@dreispt @Deriman-Alonso
Translated using Weblate (Portuguese (Portugal))
6856329 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_activity/pt_PT/
@brian10048 @Deriman-Alonso
[IMP] fieldservice_activity: black, isort, prettier
16e21a2
@brian10048 @Deriman-Alonso
[MIG] fieldservice_activity: Migratation to 13.0
c8a8f24
@ibuioli @Deriman-Alonso
Translated using Weblate (Spanish (Argentina))
66d1048 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-13.0/field-service-13.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice_activity/es_AR/
@Deriman-Alonso
[13.0][IMP] testcase
a308ace
@Deriman-Alonso
[FIX] FSM Template Activities wipe out after assigned in FSM order
85d4ce7
@Deriman-Alonso
[13.0][FIX] Update activities for FSM orders that are generate from SO
dc0c4f0
@OCA-git-bot @Deriman-Alonso
fieldservice_activity 13.0.1.0.1
a68f76a
@Freni-OSI @Deriman-Alonso
[14.0][MIG] fieldservice_activity
0672044
@oca-travis @Deriman-Alonso
[UPD] Update fieldservice_activity.pot
5505528
@OCA-git-bot @Deriman-Alonso
[UPD] README.rst
89ecd45
@mymage @Deriman-Alonso
Added translation using Weblate (Italian)
27e49cc
@mymage @Deriman-Alonso
Translated using Weblate (Italian)
03d1afa 
Currently translated at 100.0% (28 of 28 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_activity/it/
@Freni-OSI @Deriman-Alonso
[15.0][FIX] Fixed Travis
9d58e5a
@Freni-OSI @Deriman-Alonso
[15.0][MIG] fieldservice_activity
e0041b3
@Deriman-Alonso
[UPD] Update fieldservice_activity.pot
896cf1a
@OCA-git-bot @Deriman-Alonso
[UPD] README.rst
8e07c6a
@weblate @Deriman-Alonso
Update translation files
d0856bc 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-15.0/field-service-15.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_activity/
@mymage @Deriman-Alonso
Translated using Weblate (Italian)
b13e2c6 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_activity/it/
@gbrito @Deriman-Alonso
[MIG] fieldservice_activity: Migration to 16.0
28b805f
Ivorra78 and others added 6 commits April 23, 2024 14:10
@Ivorra78 @Deriman-Alonso
Added translation using Weblate (Spanish)
320dcda
@Ivorra78 @Deriman-Alonso
Translated using Weblate (Spanish)
29255be 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/es/
@adrianojprado @Deriman-Alonso
Translated using Weblate (Portuguese (Brazil))
a55d9ab 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/pt_BR/
@OCA-git-bot @Deriman-Alonso
[UPD] README.rst
bf05500
@adrianojprado @Deriman-Alonso
Translated using Weblate (Portuguese (Brazil))
9d66956 
Currently translated at 100.0% (27 of 27 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_activity
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_activity/pt_BR/
@Deriman-Alonso
[IMP] fieldservice_activity: pre-commit auto fixes
12fe016
@max3903 max3903 modified the milestone: 17.0 Jun 17, 2024
@max3903
Copy link
Sponsor Member

max3903 commented Jun 17, 2024

/ocabot migration fieldservice_activity

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 17, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 17, 2024
Open
46 tasks
DorianMAG
DorianMAG approved these changes Jul 31, 2024
View reviewed changes
Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Code review, it looks good.
Thx for the work

@DorianMAG
Copy link

@Deriman-Alonso or @max3903
Possible to rebase plz.
Runboat doesn't work

@Deriman-Alonso
Copy link
Member Author

@DorianMAG Pre-commit changed some stuff in intex.html, hopefully runboat will run now.

JulienMartinez
JulienMartinez approved these changes Jul 31, 2024
View reviewed changes
Copy link

@JulienMartinez JulienMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
LGTM
thx

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@DorianMAG
Copy link

@DorianMAG Pre-commit changed some stuff in intex.html, hopefully runboat will run now.

Thx,
perfect was work :)

DorianMAG
DorianMAG suggested changes Jul 31, 2024
View reviewed changes
Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional testing failed.
Unable to edit read-only fields conditioned by expression. Syntax changed in v17.

https://github.com/OCA/field-service/pull/1183/files#diff-e7e26d6a3ed185daa05317dcf7ed3457ff1831d1fb55c788d669372c2d38fd4dR12

The XML syntax is as follows:
https://www.odoo.com/documentation/17.0/developer/reference/user_interface/view_architectures/field_attribute_readonly.html

but I have not found the syntax for declaring fields in Python.

@Deriman-Alonso
Copy link
Member Author

I will look into it, Ty for review.

DorianMAG
DorianMAG suggested changes Jul 31, 2024
View reviewed changes
fieldservice_activity/views/fsm_order.xml
string="Complete"
type="object"
class="oe_highlight"
invisible="('state', 'not in', ['todo'])"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the syntax change for:

invisible="state not in ['todo']"

@dreispt dreispt mentioned this pull request Sep 14, 2024
Merged
@dreispt
Copy link
Sponsor Member

dreispt commented Sep 14, 2024

Superseded by #1211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorianMAG DorianMAG DorianMAG requested changes

@dreispt dreispt dreispt approved these changes

@JulienMartinez JulienMartinez JulienMartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.