Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] web_leaflet_lib #383

Open
wants to merge 4 commits into
base: 17.0
Choose a base branch
from

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Oct 29, 2024

Trivial migration.

Commit to review : c570d60

legalsylvain and others added 4 commits October 29, 2024 11:24
…aflet_lib, to be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)
- Bump version.
- Remove obsolete hook. (that was usefull during the refactoring done here OCA#380)
@legalsylvain
Copy link
Contributor Author

/ocabot migration web_leaflet_lib

@OCA-git-bot
Copy link
Contributor

Sorry @legalsylvain you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain legalsylvain changed the title 17.0 mig web leaflet lib [17.0][MIG] web_leaflet_lib Oct 29, 2024
@weinni2000
Copy link

@legalsylvain:
Did you also already convert web_view_leaflet_map to 17/18?
Because otherwise I would like to contribute to that. There is already a demo project in OWL2 from AJScript
https://github.com/ajscriptmedia/odoo-map-view-type/tree/model-arch-parser
Do you know who is the maintainer of geospatial because I need help on the PR for the base geoengine migration to 18.

@legalsylvain
Copy link
Contributor Author

Hi @weinni2000.

regards.

@yvaucher
Copy link
Member

/ocabot migration web_leaflet_lib

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 12, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#349) has not been updated to reference the current pull request because a previous pull request (#381) is not closed.
Perhaps you should check that there is no duplicate work.
CC @drkpkg

@lmignon
Copy link
Contributor

lmignon commented Nov 12, 2024

/ocabot migration web_leaflet_lib

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 12, 2024
4 tasks
@yvaucher
Copy link
Member

@weinni2000 Noone volunteered to migrate web_view_leaflet_map yet, contributions are welcome
If you do so please leave a note in one of those issues:
in 17.0 #349
in 18.0 #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants