Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] RiBa: conferma fatture senza conto bancario da list view #4351

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[FIX] RiBa: conferma fatture senza conto bancario da list view #4351

merged 1 commit into from
Sep 9, 2024

Conversation

SirAionTech
Copy link
Contributor

@SirAionTech SirAionTech commented Sep 3, 2024 •
edited
Loading

Risolve #4304 per 16.0.

Forward port di 0aef745 (di #4306).

@SirAionTech SirAionTech mentioned this pull request Sep 3, 2024
Closed
2 tasks
@SirAionTech SirAionTech linked an issue Sep 3, 2024 that may be closed by this pull request
RiBa: conferma fatture senza conto bancario da list view #4304
Closed
2 tasks
@SirAionTech SirAionTech marked this pull request as ready for review September 3, 2024 16:11
francesco-ooops
francesco-ooops approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionale ok!

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Sep 5, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionale OK

@aleuffre @SirAionTech
[IMP] l10n_it_riba: stop invoice confirmation without bank
5106b58 
Cannot confirm an invoice with C/O (RiBa) payment if the bank has not
been set on the invoice.

Co-authored-by: SirAionTech <[email protected]>
@SirAionTech
Copy link
Contributor Author

Fatto rebase per risolvere i conflitti

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

aleuffre
aleuffre approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@tafaRU
Copy link
Member

tafaRU commented Sep 9, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-4351-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6c180de into OCA:16.0 Sep 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7eabb76. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@aleuffre aleuffre aleuffre approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RiBa: conferma fatture senza conto bancario da list view
6 participants
@SirAionTech @OCA-git-bot @tafaRU @francesco-ooops @aleuffre @MaurizioPellegrinet